Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CHANGE][NMP-628] Update fertilizer static data #636

Merged
merged 2 commits into from
Mar 20, 2024

Conversation

fergmac
Copy link
Contributor

@fergmac fergmac commented Mar 19, 2024

Pull Request Standards

  • The title of the PR is accurate
  • The title includes the type of change [HOTFIX, FEATURE, etc]
  • The PR title includes the ticket number in format of [NMP-###]
  • Documentation is updated to reflect change [README, functions, team documents]

Description

This PR includes the following proposed change(s):

  • Adding more berry fertilizers to the list of fertilizers in static data

Screenshot 2024-03-19 at 4 09 17 PM

Screenshot 2024-03-19 at 4 09 26 PM

@fergmac fergmac requested a review from acatchpole March 19, 2024 23:05
@fergmac fergmac self-assigned this Mar 19, 2024
Copy link
Contributor

@acatchpole acatchpole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also need to update

public const string StaticDataVersion = "Agri.Data.SeedData.StaticDataVersion_12.json";

in app/Agri.Data/Constants.cs

@@ -8,6 +8,7 @@
<None Remove="SeedData\DepthsData.json" />
<None Remove="SeedData\StaticDataVersion_10.json" />
<None Remove="SeedData\StaticDataVersion_11.json" />
<None Remove="SeedData\StaticDataVersion_13.json" />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<None Remove="SeedData\StaticDataVersion_13.json" />
<None Remove="SeedData\StaticDataVersion_12.json" />

In #635, we set the remove to the previous version. Still not totally sure what is necessary, but it DID work in that PR

@fergmac fergmac changed the title Update static data version. [CHANGE][NMP-628] Update fertilizer static data Mar 20, 2024
@fergmac fergmac requested a review from acatchpole March 20, 2024 17:59
@fergmac fergmac merged commit 36c4d61 into master Mar 20, 2024
1 check passed
@fergmac fergmac deleted the nmp-628-berry-fertilizers branch March 20, 2024 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants