Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added ability to cache genesis trans for 24h #1613

Merged
merged 10 commits into from
Nov 23, 2023
Merged

Conversation

wadeking98
Copy link
Contributor

@wadeking98 wadeking98 commented Nov 20, 2023

implemented caching for ledger genesis transactions.
The wallet will refresh the cache every 24 hours on load.
if the cache needs to be refreshes the wallet will refresh the pool and fetch the new genesis transactions. doing this also automatically updates the current agent transaction pool. The transactions are saved in local storage so we don't have to fetch them the next time we startup.

Note: this change also seems to improve performance with sorvin:staging network but more testing is needed

The following gifs were created with a local production build of the wallet:

Accept LSBC credential:

lsbc-credential-accept

a2a proof request:

a2a-dev-proof

@wadeking98 wadeking98 added the do not merge This PR is on hold. label Nov 21, 2023
Signed-off-by: wadeking98 <[email protected]>
Signed-off-by: wadeking98 <[email protected]>
Signed-off-by: wadeking98 <[email protected]>
@jleach jleach marked this pull request as draft November 22, 2023 19:40
Signed-off-by: wadeking98 <[email protected]>
Signed-off-by: wadeking98 <[email protected]>
@wadeking98 wadeking98 removed the do not merge This PR is on hold. label Nov 22, 2023
@wadeking98 wadeking98 marked this pull request as ready for review November 22, 2023 23:35
Copy link
Contributor

@bryce-mcmath bryce-mcmath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something seems odd about the one patch, everything else LGTM

package.json Outdated Show resolved Hide resolved
Signed-off-by: wadeking98 <[email protected]>
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Member

@cvarjao cvarjao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wadeking98 wadeking98 merged commit d586bc9 into main Nov 23, 2023
9 checks passed
@wadeking98 wadeking98 deleted the feat-ledger-cache branch November 23, 2023 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants