Skip to content

Commit

Permalink
- app version = 5.11.9 (#722)
Browse files Browse the repository at this point in the history
- added vue-auto-resize package
- allow filings in Change Requested status for temp id case only
- store filing status (tombstone, getter, action)
- added font size base style
- added Change Requested message box
- renamed isShowReviewConfirmBtn() -> isShowNextBtn()
- updated File and Pay button label
- updated Filing Status enum
- updated misc interfaces for new header property (latestReviewComment)
- now restore expro registration confirmation checkbox (isConfirmed)
- waive fees when filing is Change Requested
- updated isContinuationValid()
- only allow change to effective date/time when not Draft
- only show staff payment step when filing is Draft
- misc cleanup
- added/updated unit tests

Co-authored-by: Severin Beauvais <[email protected]>
  • Loading branch information
severinbeauvais and Severin Beauvais authored Jul 29, 2024
1 parent 4163c81 commit 5b33cc6
Show file tree
Hide file tree
Showing 16 changed files with 307 additions and 77 deletions.
10 changes: 8 additions & 2 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 2 additions & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "business-create-ui",
"version": "5.11.8",
"version": "5.11.9",
"private": true,
"appName": "Create UI",
"sbcName": "SBC Common Components",
Expand Down Expand Up @@ -60,6 +60,7 @@
"uuid": "^9.0.0",
"vue": "2.7.16",
"vue-affix": "^0.5.2",
"vue-auto-resize": "^1.0.1",
"vue-hotjar": "^1.4.0",
"vue-observe-visibility": "^1.0.0",
"vue-router": "^3.6.5",
Expand Down
19 changes: 9 additions & 10 deletions src/App.vue
Original file line number Diff line number Diff line change
Expand Up @@ -326,6 +326,7 @@ export default class App extends Mixins(CommonMixin, DateMixin, FilingTemplateMi
@Action(useStore) setCurrentStep!: (x: number) => void
@Action(useStore) setEntityState!: (x: EntityStates) => void
@Action(useStore) setFeePrices!: (x: Array<FeesIF>) => void
@Action(useStore) setFilingStatus!: (x: FilingStatus) => void
@Action(useStore) setFilingType!: (x: FilingTypes) => void
@Action(useStore) setGoodStanding!: (x: boolean) => void
@Action(useStore) setIdentifier!: (x: string) => void
Expand Down Expand Up @@ -866,8 +867,8 @@ export default class App extends Mixins(CommonMixin, DateMixin, FilingTemplateMi
this.setFilingType(draftFiling.header.name)
// check if filing is in a valid state to be edited
this.filingNotExistDialog = !this.hasValidFilingState(draftFiling)
if (this.filingNotExistDialog) return null
this.filingNotExistDialog = (draftFiling?.header?.status !== FilingStatus.DRAFT)
if (this.filingNotExistDialog) return null // don't continue
// parse draft filing into the store and get the resources
let resources: ResourceIF
Expand Down Expand Up @@ -921,10 +922,14 @@ export default class App extends Mixins(CommonMixin, DateMixin, FilingTemplateMi
let draftFiling = await LegalServices.fetchFirstOrOnlyFiling(tempId)
this.setFilingType(draftFiling.header.name)
this.setFilingStatus(draftFiling.header.status)
// check if filing is in a valid state to be edited
this.filingNotExistDialog = !this.hasValidFilingState(draftFiling)
if (this.filingNotExistDialog) return null
this.filingNotExistDialog = (
draftFiling?.header?.status !== FilingStatus.DRAFT &&
draftFiling?.header?.status !== FilingStatus.CHANGE_REQUESTED
)
if (this.filingNotExistDialog) return null // don't continue
// parse draft filing into the store and get the resources
let resources: ResourceIF
Expand Down Expand Up @@ -985,12 +990,6 @@ export default class App extends Mixins(CommonMixin, DateMixin, FilingTemplateMi
}
}
/** Used to check if the filing is in a valid state for changes. */
private hasValidFilingState (filing: any): boolean {
const filingStatus = filing?.header?.status
return (filingStatus === FilingStatus.DRAFT)
}
/**
* Fetches NR, validates it, and stores the data.
* This method is different from _validateNameRequest() in Actions.vue. On error, this method displays
Expand Down
4 changes: 4 additions & 0 deletions src/assets/styles/base.scss
Original file line number Diff line number Diff line change
Expand Up @@ -245,6 +245,10 @@ p {
font-size: $px-15;
}

.font-16 {
font-size: $px-16;
}

.error-text {
color: $app-red !important;
}
Expand Down
63 changes: 59 additions & 4 deletions src/components/ContinuationIn/ContinuationAuthorization.vue
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,34 @@

<v-divider class="mt-4 mb-8" />

<header>
<MessageBox
v-if="isShowMessageBox"
color="red"
>
<v-icon color="error">
mdi-alert
</v-icon>

<label
class="font-16"
for="textarea-message"
>
Change Requested:
</label>

<textarea
id="textarea-message"
v-auto-resize
class="font-16 font-italic ml-8"
readonly
rows="1"
:value="latestReviewComment"
/>
</MessageBox>

<header
:class="{ 'mt-6': isShowMessageBox }"
>
<p>
Upload documents that support proof of authorization from your home jursidiction.
</p>
Expand Down Expand Up @@ -105,15 +132,21 @@ import { StatusCodes } from 'http-status-codes'
import { useStore } from '@/store/store'
import { DocumentMixin } from '@/mixins'
import { ContinuationAuthorizationIF, ExistingBusinessInfoIF, FormIF, PresignedUrlIF } from '@/interfaces'
import { PdfPageSize } from '@/enums'
import { FilingStatus, PdfPageSize } from '@/enums'
import { VuetifyRuleFunction } from '@/types'
import FileUploadPreview from '@/components/common/FileUploadPreview.vue'
import { DatePicker as DatePickerShared } from '@bcrs-shared-components/date-picker'
import AutoResize from 'vue-auto-resize'
import MessageBox from '@/components/common/MessageBox.vue'
@Component({
components: {
DatePickerShared,
FileUploadPreview
FileUploadPreview,
MessageBox
},
directives: {
AutoResize
}
})
export default class ExtraproRegistration extends Mixins(DocumentMixin) {
Expand All @@ -128,6 +161,7 @@ export default class ExtraproRegistration extends Mixins(DocumentMixin) {
@Getter(useStore) getContinuationAuthorization!: ContinuationAuthorizationIF
@Getter(useStore) getCurrentDate!: string
@Getter(useStore) getExistingBusinessInfo!: ExistingBusinessInfoIF
@Getter(useStore) getFilingStatus!: FilingStatus
@Getter(useStore) getKeycloakGuid!: string
@Getter(useStore) getShowErrors!: boolean
Expand Down Expand Up @@ -167,6 +201,18 @@ export default class ExtraproRegistration extends Mixins(DocumentMixin) {
]
}
/** The latest review comment. Only used when filing is in Change Requested status. */
get latestReviewComment (): string {
return this.getExistingBusinessInfo.latestReviewComment
}
get isShowMessageBox (): boolean {
return (
(this.getFilingStatus === FilingStatus.CHANGE_REQUESTED) &&
!!this.latestReviewComment
)
}
/** The number of file upload components to display (max 5). */
get numUploads (): number {
return Math.min((this.authorization.files.length + 1), 5)
Expand Down Expand Up @@ -276,7 +322,7 @@ header {
}
}
// set style for all root labels
// set style for all labels
label {
font-weight: bold;
color: $gray9;
Expand All @@ -300,6 +346,15 @@ label {
}
}
textarea {
color: $gray7;
width: 100%;
resize: none;
// FUTURE: use field-sizing instead of "v-auto-resize" directive
// ref: https://developer.mozilla.org/en-US/docs/Web/CSS/field-sizing
// field-sizing: content;
}
// align the checkbox with its label
:deep(.v-input--checkbox .v-input__slot) {
align-items: flex-start;
Expand Down
Loading

0 comments on commit 5b33cc6

Please sign in to comment.