19359 - Amalgamating Businesses Table must have more than 1 (#628)

* Fixed amalgamating business length to be more than 1

* Rebased + fixed Sev's comment + added unit tests

* Fixed lint issues

* removed unneeded nextTick in tests

package.json

@@ -1,6 +1,6 @@
 {
   "name": "business-create-ui",
-  "version": "5.6.42",
+  "version": "5.6.43",
   "private": true,
   "appName": "Create UI",
   "sbcName": "SBC Common Components",

src/components/Amalgamation/BusinessTable.vue

@@ -181,7 +181,7 @@ export default class BusinessTable extends Mixins(AmalgamationMixin) {
   @Emit('valid')
   private emitValidity (): boolean {
     return (
-      (this.businesses.length > 0) &&
+      (this.businesses.length >= 2) &&
       this.businesses.every(business => business.status === AmlStatuses.OK)
     )
   }

tests/unit/BusinessTable.spec.ts

@@ -169,6 +169,121 @@ describe('Business Table - display', () => {
   }
 })
 
+describe('Business Table - validity', () => {
+  it('emit invalid when there are no businesses in the table', () => {
+    const wrapper = wrapperFactory(
+      BusinessTable,
+      null,
+      {
+        amalgamation: {
+          amalgamatingBusinesses: []
+        }
+      }
+    )
+
+    expect(wrapper.emitted('valid').pop()[0]).toEqual(false)
+  })
+
+  it('emit invalid when there is only one business in the table', () => {
+    const wrapper = wrapperFactory(
+      BusinessTable,
+      null,
+      {
+        amalgamation: {
+          amalgamatingBusinesses: [
+            {
+              address: {
+                addressCity: 'Victoria',
+                addressCountry: 'CA',
+                addressRegion: 'BC',
+                addressType: 'mailing',
+                deliveryInstructions: '',
+                postalCode: 'X8Y 1X1',
+                streetAddress: 'test street',
+                streetAddressAdditional: ''
+              },
+              email: '[email protected]',
+              identifier: 'BC1111111',
+              isFrozen: false,
+              isFutureEffective: false,
+              isLimitedRestoration: false,
+              isNotInGoodStanding: false,
+              legalType: CorpTypeCd.BENEFIT_COMPANY,
+              name: 'TEST BEN',
+              role: AmlRoles.AMALGAMATING,
+              status: AmlStatuses.OK,
+              type: AmlTypes.LEAR
+            }
+          ]
+        }
+      }
+    )
+
+    expect(wrapper.emitted('valid').pop()[0]).toEqual(false)
+  })
+
+  it('emit valid when there are two or more businesses in the table', () => {
+    const wrapper = wrapperFactory(
+      BusinessTable,
+      null,
+      {
+        amalgamation: {
+          amalgamatingBusinesses: [
+            {
+              address: {
+                addressCity: 'Victoria',
+                addressCountry: 'CA',
+                addressRegion: 'BC',
+                addressType: 'mailing',
+                deliveryInstructions: '',
+                postalCode: 'X8Y 1X1',
+                streetAddress: 'test street',
+                streetAddressAdditional: ''
+              },
+              email: '[email protected]',
+              identifier: 'BC1111111',
+              isFrozen: false,
+              isFutureEffective: false,
+              isLimitedRestoration: false,
+              isNotInGoodStanding: false,
+              legalType: CorpTypeCd.BENEFIT_COMPANY,
+              name: 'TEST BEN',
+              role: AmlRoles.AMALGAMATING,
+              status: AmlStatuses.OK,
+              type: AmlTypes.LEAR
+            },
+            {
+              address: {
+                addressCity: 'Victoria',
+                addressCountry: 'CA',
+                addressRegion: 'BC',
+                addressType: 'mailing',
+                deliveryInstructions: '',
+                postalCode: 'X8Y 1X2',
+                streetAddress: 'test street 2',
+                streetAddressAdditional: ''
+              },
+              email: '[email protected]',
+              identifier: 'BC2222222',
+              isFrozen: false,
+              isFutureEffective: false,
+              isLimitedRestoration: false,
+              isNotInGoodStanding: false,
+              legalType: CorpTypeCd.BC_COMPANY,
+              name: 'TEST BEN NUMBER 2',
+              role: AmlRoles.AMALGAMATING,
+              status: AmlStatuses.OK,
+              type: AmlTypes.LEAR
+            }
+          ]
+        }
+      }
+    )
+
+    expect(wrapper.emitted('valid').pop()[0]).toBe(true)
+  })
+})
+
 // *** FUTURE: get this working
 // ATM, local rules are mocked (eg, wrapper.vm.notAffiliated()), but not the actual rules in the mixin.
 // It's probably this: https://vitest.dev/guide/mocking.html#mocking-pitfalls.