Skip to content

Commit

Permalink
Merge pull request #213 from cameron-freshworks/6858-UX
Browse files Browse the repository at this point in the history
Incorp Agreement Ux Updates
  • Loading branch information
andrepestana-aot authored Jun 28, 2021
2 parents f5c354c + 862f4c0 commit 82bad41
Show file tree
Hide file tree
Showing 6 changed files with 13 additions and 12 deletions.
2 changes: 1 addition & 1 deletion package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "business-create-ui",
"version": "2.0.1",
"version": "2.0.2",
"private": true,
"appName": "Create UI",
"sbcName": "SBC Common Components",
Expand Down
4 changes: 2 additions & 2 deletions src/resources/limitedCompany.ts
Original file line number Diff line number Diff line change
Expand Up @@ -61,12 +61,12 @@ export const LimitedCompanyResource: ResourceIF = {
documents: [
{
code: 'Table-1',
description: 'The <b>sample Incorporation Agreement and Table 1 Articles</b> containing a provision ' +
description: 'The <b>sample Incorporation Agreement and Table 1 Articles</b> ' +
'has been completed and a copy has been added to the company\'s record book.'
},
{
code: 'custom',
description: 'The <b>custom Incorporation Agreement and custom Articles</b> containing a provision ' +
description: 'The <b>custom Incorporation Agreement and custom Articles</b> ' +
'has been completed and a copy has been added to the company\'s record book.'
}
]
Expand Down
4 changes: 2 additions & 2 deletions src/resources/unlimitedCompany.ts
Original file line number Diff line number Diff line change
Expand Up @@ -62,12 +62,12 @@ export const UnlimitedCompanyResource: ResourceIF = {
documents: [
{
code: 'Table-1',
description: 'The <b>sample Incorporation Agreement and Table 1 Articles</b> containing a provision ' +
description: 'The <b>sample Incorporation Agreement and Table 1 Articles</b> ' +
'has been completed and a copy has been added to the company\'s record book.'
},
{
code: 'custom',
description: 'The <b>custom Incorporation Agreement and custom Articles</b> containing a provision ' +
description: 'The <b>custom Incorporation Agreement and custom Articles</b> ' +
'has been completed and a copy has been added to the company\'s record book.'
}
]
Expand Down
5 changes: 3 additions & 2 deletions src/views/IncorporationAgreement.vue
Original file line number Diff line number Diff line change
Expand Up @@ -123,8 +123,8 @@
<ul>
<li>
The company is required to keep signed copies of the Incorporation Agreement and Articles in the
company’s record book. For a complete list of records a company is required to keep please see section
42 of the Business Corporations Act.
company’s record book. For a complete list of records a company is required to keep please see
<a :href="section42Url" target="_blank">section 42</a> of the Business Corporations Act.
</li>
</ul>
</div>
Expand Down Expand Up @@ -230,6 +230,7 @@ export default class IncorporationAgreement extends Mixins(EnumMixin) {
// Local properties
private helpToggle: boolean = false
private readMoreFlag: boolean = false
readonly section42Url = `https://www.bclaws.gov.bc.ca/civix/document/id/complete/statreg/02057_02#section42`
/** The entity description, */
private get getEntityDescription (): string {
Expand Down
8 changes: 4 additions & 4 deletions tests/unit/AgreementType.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -41,9 +41,9 @@ const agreementTypeTestCases = [
customAgreement: {
agreementType: 'custom'
},
sampleSummaryText: 'The sample Incorporation Agreement and Table 1 Articles containing a provision ' +
sampleSummaryText: 'The sample Incorporation Agreement and Table 1 Articles ' +
'has been completed and a copy has been added to the company\'s record book.',
customSummaryText: 'The custom Incorporation Agreement and custom Articles containing a provision ' +
customSummaryText: 'The custom Incorporation Agreement and custom Articles ' +
'has been completed and a copy has been added to the company\'s record book.'
},
{
Expand All @@ -54,9 +54,9 @@ const agreementTypeTestCases = [
customAgreement: {
agreementType: 'custom'
},
sampleSummaryText: 'The sample Incorporation Agreement and Table 1 Articles containing a provision ' +
sampleSummaryText: 'The sample Incorporation Agreement and Table 1 Articles ' +
'has been completed and a copy has been added to the company\'s record book.',
customSummaryText: 'The custom Incorporation Agreement and custom Articles containing a provision ' +
customSummaryText: 'The custom Incorporation Agreement and custom Articles ' +
'has been completed and a copy has been added to the company\'s record book.'
}
]
Expand Down

0 comments on commit 82bad41

Please sign in to comment.