- app version = 5.12.8 (#750)

- fixed share structure button styles (outlined)
- added punctuation to some hint text
- bolded and fixed layout of share structure instruction text (x3)
- changed incorporation -> continuation in document delivery section
- updated unit tests

Co-authored-by: Severin Beauvais <[email protected]>

package.json

@@ -1,6 +1,6 @@
 {
   "name": "business-create-ui",
-  "version": "5.12.7",
+  "version": "5.12.8",
   "private": true,
   "appName": "Create UI",
   "sbcName": "SBC Common Components",

src/components/ContinuationIn/ExtraproRegistration.vue

@@ -152,7 +152,7 @@
               filled
               persistent-hint
               label="Business Number (Optional)"
-              hint="First 9 digits of the CRA Business Number if you have one"
+              hint="First 9 digits of the CRA Business Number, if you have one."
               :rules="getShowErrors ? Rules.BusinessNumberRules : []"
             />
 
@@ -164,7 +164,7 @@
               title="Date of Incorporation"
               :nudgeRight="40"
               :nudgeTop="85"
-              hint="Date of Incorporation, Continuation or Amalgamation in previous jurisdiction"
+              hint="Date of Incorporation, Continuation or Amalgamation in previous jurisdiction."
               :persistentHint="true"
               :initialValue="business.prevIncorporationDate"
               :inputRules="getShowErrors ? incorporationDateRules: []"

src/components/ContinuationIn/ManualBusinessInfo.vue

@@ -118,7 +118,7 @@
               filled
               persistent-hint
               label="Business Number (Optional)"
-              hint="First 9 digits of the CRA Business Number if you have one"
+              hint="First 9 digits of the CRA Business Number, if you have one."
               :rules="getShowErrors ? Rules.BusinessNumberRules : []"
             />
 
@@ -130,7 +130,7 @@
               title="Date of Incorporation"
               :nudgeRight="40"
               :nudgeTop="85"
-              hint="Date of Incorporation, Continuation or Amalgamation in previous jurisdiction"
+              hint="Date of Incorporation, Continuation or Amalgamation in previous jurisdiction."
               :persistentHint="true"
               :initialValue="getExistingBusinessInfo.prevIncorporationDate"
               :inputRules="getShowErrors ? incorporationDateRules : []"

src/components/common/ShareStructure.vue

@@ -159,6 +159,7 @@
                   <v-btn
                     id="btn-remove"
                     large
+                    outlined
                     color="error"
                     :disabled="activeIndex === -1"
                     @click="removeShareStructure()"
@@ -180,6 +181,8 @@
                   <v-btn
                     id="btn-cancel"
                     large
+                    outlined
+                    color="primary"
                     @click="resetFormAndData(true)"
                   >
                     Cancel

src/views/Amalgamation/ShareStructure.vue

@@ -79,8 +79,10 @@
       </section>
     </v-expand-transition>
 
-    <p>Your application must include the following:</p>
-    <ul>
+    <div class="mt-4 font-weight-bold">
+      Your application must include the following:
+    </div>
+    <ul class="mt-2">
       <li>
         <v-icon
           v-if="shareClasses.length > 0"

src/views/ContinuationIn/ContinuationInReviewConfirm.vue

@@ -119,7 +119,7 @@
       <header>
         <h2>Document Delivery</h2>
         <p class="mt-4">
-          Copies of the incorporation documents will be sent to the email addresses listed below.
+          Copies of the continuation documents will be sent to the email addresses listed below.
         </p>
       </header>
 

src/views/ContinuationIn/ContinuationInShareStructure.vue

@@ -79,9 +79,11 @@
       </section>
     </v-expand-transition>
 
-    <section class="pt-2">
-      <p>Your application must include the following:</p>
-      <ul>
+    <section class="mt-4">
+      <div class="font-weight-bold">
+        Your application must include the following:
+      </div>
+      <ul class="mt-2">
         <li>
           <v-icon
             v-if="shareClasses.length > 0"

src/views/Incorporation/IncorporationShareStructure.vue

@@ -79,8 +79,10 @@
       </section>
     </v-expand-transition>
 
-    <p>Your application must include the following:</p>
-    <ul>
+    <div class="mt-4 font-weight-bold">
+      Your application must include the following:
+    </div>
+    <ul class="mt-2">
       <li>
         <v-icon
           v-if="shareClasses.length > 0"

tests/unit/ContinuationInReviewConfirm.spec.ts

@@ -100,7 +100,7 @@ describe('Continuation In Review Confirm component', () => {
     // spot check some content (structure / text)
     const thirdSection = wrapper.findAll('#continuation-in-review-confirm > section').at(2)
     expect(thirdSection.find('header h2').text()).toBe('Document Delivery')
-    expect(thirdSection.find('header p').text()).toContain('Copies of the incorporation documents will')
+    expect(thirdSection.find('header p').text()).toContain('Copies of the continuation documents will')
     expect(thirdSection.findComponent(DocumentDelivery).exists()).toBe(true)
 
     wrapper.destroy()

tests/unit/ContinuationInShareStructure.spec.ts

@@ -27,7 +27,7 @@ describe('Continuation In Share Structure component', () => {
     // NB: third section is in the help block
 
     const fourthSection = wrapper.findAll('section').at(3)
-    expect(fourthSection.find('p').text()).toBe('Your application must include the following:')
+    expect(fourthSection.find('div').text()).toBe('Your application must include the following:')
 
     expect(wrapper.find('#btn-start-add-cp').exists()).toBe(true)
     wrapper.destroy()