24141 - Added founding date not changed from Colin #755
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Qin <[email protected]>
|
/gcbrun |
|
Temporary Url for review: https://business-create-dev--pr-755-z1jrh228.web.app SB says, try this: https://business-create-dev--pr-755-z1jrh228.web.app/continuation-in-authorization?id=TccWOxq2Ov |
|
now the foundingDate is in the same format as Colin: |
src/interfaces/store-interfaces/state-interfaces/existing-business-info-interface.ts
Outdated
Show resolved
Hide resolved
Signed-off-by: Qin <[email protected]>
|
/gcbrun |
|
Temporary Url for review: https://business-create-dev--pr-755-z1jrh228.web.app |
severinbeauvais
approved these changes
Oct 30, 2024
Signed-off-by: Qin <[email protected]>
|
Probably not intentional, but I think here the version should've been 5.13.1 as this is a small patch. Please watch out for next time, thank you! |
|
Yes, this was an oopsie. I said it was ok to leave it.
…________________________________
From: Karim El Jazzar ***@***.***>
Sent: Wednesday, November 6, 2024 4:27:33 PM
To: bcgov/business-create-ui ***@***.***>
Cc: Beauvais, Severin ***@***.***>; Review requested ***@***.***>
Subject: Re: [bcgov/business-create-ui] 24141 - Added founding date not changed from Colin (PR #755)
CAUTION: This email originated from outside of Quartech. Do not click links or open attachments unless you recognize the sender and know the content is safe.
Probably not intentional, but I think here the version should've been 5.13.1 as this is a small patch. Please watch out for next time, thank you!
1_S0S5Qv9AK3mc1M3Vq39nPQ.jpg (view on web)<https://github.com/user-attachments/assets/310fdad6-677f-449b-b34e-326998911dd2>
—
Reply to this email directly, view it on GitHub<#755 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ACMKDSOSM62CKLU2BOISTTDZ7KXXLAVCNFSM6AAAAABQ5AZXJKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINRRGA3TKNRSGA>.
You are receiving this because your review was requested.Message ID: ***@***.***>
|
|
Thank you! I will pay attention next time |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #: /bcgov/entity#24141
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the bcrs-entities-create-ui license (Apache 2.0).