23970 - Allow editable certify legal name #756
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/gcbrun |
|
Temporary Url for review: https://business-create-dev--pr-756-xdzm8n18.web.app Complete Url for review: https://business-create-dev--pr-756-xdzm8n18.web.app/amalg-short-review-confirm?id=TkxQPsgl5F&accountid=3633 |
JazzarKarim
approved these changes
Nov 4, 2024
severinbeauvais
approved these changes
Nov 5, 2024
|
Just found, the Edit_UI has implemented the Certify Section a bit differently. There is a CertifySection component created based on Certify component in Edit UI. And it sets the default value to |
AimeeGao
force-pushed
the
23970-create-ui-allow-editable-certify-legal-name
branch
from
2452fb5 to
3dd5d08
Compare
|
/gcbrun |
|
You can merge when ready. |
|
Temporary Url for review: https://business-create-dev--pr-756-xdzm8n18.web.app |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #: /bcgov/entity#23970
Description of changes:
Updated the Certify Legal Name editing condition on the Review/Confirm page to allow editing of the legal name for all users.
Note:
According to Mihai's feedback, firms and coops types are not considered in this bug fix.
Result:
Before:
After:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the bcrs-entities-create-ui license (Apache 2.0).