Merge pull request #594 from eason-pan-bc/23971-allow-editable-certif…

…y-legal-name 23971 - allow editable certify legal name for corps as regular users
bcgov · Nov 2, 2024 · bc543b2 · bc543b2
2 parents eb99042 + e14e83f
commit bc543b2
Show file tree

Hide file tree

Showing 6 changed files with 7 additions and 9 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "business-edit-ui",
-  "version": "4.11.1",
+  "version": "4.11.2",
   "private": true,
   "appName": "Edit UI",
   "sbcName": "SBC Common Components",

diff --git a/src/views/Alteration.vue b/src/views/Alteration.vue
@@ -75,7 +75,6 @@
             class="mt-10"
             :sectionNumber="showTransactionalFolioNumber ? '3.' : '2.'"
             :validate="getAppValidate"
-            :disableEdit="!isRoleStaff"
           />
 
           <!-- STAFF ONLY: Court Order/Plan of Arrangement and Staff Payment -->

diff --git a/src/views/SpecialResolution.vue b/src/views/SpecialResolution.vue
@@ -97,7 +97,6 @@
             class="mt-10"
             :sectionNumber="showTransactionalFolioNumber ? '4.' : '3.'"
             :validate="getAppValidate"
-            :disableEdit="!isRoleStaff"
           />
 
           <template v-if="isRoleStaff">

diff --git a/tests/unit/Alteration.spec.ts b/tests/unit/Alteration.spec.ts
@@ -413,7 +413,7 @@ describe('Alteration component', () => {
     expect(store.stateModel.filingData[0].filingTypeCode).toBe(FilingCodes.ALTERATION_BC_TO_ULC)
   })
 
-  it('certify text is not prefilled/editable for staff user', async () => {
+  it('certify text is not prefilled for staff user', async () => {
     store.stateModel.tombstone.keycloakRoles = ['staff']
     store.stateModel.tombstone.userInfo = {
       firstname: 'Jon',
@@ -425,7 +425,7 @@ describe('Alteration component', () => {
     expect(store.stateModel.certifyState.certifiedBy).toBe('undefined undefined')
   })
 
-  it('certify text is prefilled/uneditable for non-staff user', async () => {
+  it('certify text is prefilled for non-staff user', async () => {
     store.stateModel.tombstone.keycloakRoles = []
     store.stateModel.tombstone.userInfo = {
       firstname: 'Jon',

diff --git a/tests/unit/SpecialResolution.spec.ts b/tests/unit/SpecialResolution.spec.ts
@@ -278,7 +278,7 @@ describe('Special Resolution component', () => {
     expect(store.stateModel.currentFees[0].filingFees).toBe(70)
   })
 
-  it('certify text is not prefilled/editable for staff user', async () => {
+  it('certify text is not prefilled for staff user', async () => {
     store.stateModel.tombstone.keycloakRoles = ['staff']
     store.stateModel.tombstone.userInfo = {
       firstname: 'Jon',
@@ -290,7 +290,7 @@ describe('Special Resolution component', () => {
     expect(store.stateModel.certifyState.certifiedBy).toBe('undefined undefined')
   })
 
-  it('certify text is prefilled/uneditable for non-staff user', async () => {
+  it('certify text is prefilled for non-staff user', async () => {
     store.stateModel.tombstone.keycloakRoles = []
     store.stateModel.tombstone.userInfo = {
       firstname: 'Jon',