Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Await writing template to temp directory #110

Merged
merged 2 commits into from
Jun 26, 2024
Merged

Await writing template to temp directory #110

merged 2 commits into from
Jun 26, 2024

Conversation

TimCsaky
Copy link
Contributor

Attempt to handle a race condition during copying template from temp directory to the file cache

Description

Ticket: https://apps.nrs.gov.bc.ca/int/jira/browse/SHOWCASE-3693

  • await the completion of writing template to temp directory before progressing to move the file.
  • simplified code to define a temp file name
  • added some minor code comments

Types of changes

Bug fix (non-breaking change which fixes an issue)

Checklist

  • [x I have read the CONTRIBUTING doc
  • I have checked that unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have updated the OpenAPI 3.0 v*.api-spec.yaml documentation (if appropriate)
  • I have added necessary documentation (if appropriate)

Further comments

Copy link

github-actions bot commented Jun 26, 2024

Coverage Report

Totals Coverage
Statements: 16.04% ( 140 / 873 )
Methods: 25.71% ( 18 / 70 )
Lines: 15.33% ( 82 / 535 )
Branches: 14.93% ( 40 / 268 )

Attempt to handle a race condition during copying template
from temp directory to the file cache
@TimCsaky TimCsaky merged commit 562a81c into master Jun 26, 2024
12 of 13 checks passed
@TimCsaky TimCsaky deleted the bug/cache branch June 26, 2024 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants