Fix NPM Cache directory permission and PID Signalling bugs #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverage Report
|
|
PR Deployed at: https://cdogs-dev-pr-95.apps.silver.devops.gov.bc.ca |
jujaga
force-pushed
the
ci/fluentbit
branch
2 times, most recently
from
8ad1e64 to
2e05bb3
Compare
jujaga
requested review from
jatindersingh93,
wilwong89,
TimCsaky,
norrisng-bc,
kyle1morel and
a team
and removed request for
jatindersingh93,
wilwong89,
TimCsaky,
norrisng-bc and
kyle1morel
NPM appears to not propagate the SIGTERM signal to the child node app on alpine. This is fixed by unwrapping the call and starting the app directly instead. NPM cache directory permission issues have appeared again for some external reason, so we need to mitigate by explicitly forcing a permission update on the cache directory to be owned by a non-root user. Signed-off-by: Jeremy Ho <[email protected]>
TimCsaky
approved these changes
Nov 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
NPM appears to not propagate the SIGTERM signal to the child node app
on alpine. This is fixed by unwrapping the call and starting the app
directly instead. NPM cache directory permission issues have appeared
again for some external reason, so we need to mitigate by explicitly
forcing a permission update on the cache directory to be owned by a
non-root user.
Types of changes
Bug fix (non-breaking change which fixes an issue)
Checklist
v*.api-spec.yamldocumentation (if appropriate)Further comments