Code Review Feedback

* Rename ComplianceReportViewSelector
bcgov · Dec 18, 2024 · 1e52ca9 · 1e52ca9
1 parent 9f529de
commit 1e52ca9
Show file tree

Hide file tree

Showing 4 changed files with 12 additions and 9 deletions.
diff --git a/backend/lcfs/services/rabbitmq/report_consumer.py b/backend/lcfs/services/rabbitmq/report_consumer.py
@@ -156,6 +156,9 @@ async def handle_message(
                 )
                 user = await UserRepository(db=session).get_user_by_id(user_id)
 
+                if not user:
+                    logger.error(f"Cannot parse Report {legacy_id} from TFRS, no user with ID {user_id}")
+
                 if action == "Created":
                     await self._handle_created(
                         org_id,

diff --git a/frontend/src/App.jsx b/frontend/src/App.jsx
@@ -36,7 +36,7 @@ import { AddEditAllocationAgreements } from './views/AllocationAgreements/AddEdi
 import { logout } from '@/utils/keycloak.js'
 import { CompareReports } from '@/views/CompareReports/CompareReports'
 import { ViewLegacyComplianceReport } from '@/views/ComplianceReports/ViewLegacyComplianceReport.jsx'
-import { ViewComplianceReportBrancher } from '@/views/ComplianceReports/ViewComplianceReportBrancher.jsx'
+import { ComplianceReportViewSelector } from '@/views/ComplianceReports/ComplianceReportViewSelector.jsx'
 
 const router = createBrowserRouter([
   {
@@ -198,7 +198,7 @@ const router = createBrowserRouter([
       },
       {
         path: ROUTES.REPORTS_VIEW,
-        element: <ViewComplianceReportBrancher />,
+        element: <ComplianceReportViewSelector />,
         handle: { title: '' }
       },
       {

diff --git a/...eReports/ViewComplianceReportBrancher.jsx → ...eReports/ComplianceReportViewSelector.jsx b/...eReports/ViewComplianceReportBrancher.jsx → ...eReports/ComplianceReportViewSelector.jsx
@@ -5,7 +5,7 @@ import { ViewLegacyComplianceReport } from '@/views/ComplianceReports/ViewLegacy
 import { useParams } from 'react-router-dom'
 import { EditViewComplianceReport } from '@/views/ComplianceReports/EditViewComplianceReport.jsx'
 
-export const ViewComplianceReportBrancher = () => {
+export const ComplianceReportViewSelector = () => {
   const { complianceReportId } = useParams()
   const { data: currentUser, isLoading: isCurrentUserLoading } =
     useCurrentUser()

diff --git a/...s__/ViewComplianceReportBrancher.test.jsx → ...s__/ComplianceReportViewSelector.test.jsx b/...s__/ViewComplianceReportBrancher.test.jsx → ...s__/ComplianceReportViewSelector.test.jsx
@@ -1,7 +1,7 @@
 import React from 'react'
 import { render, screen, waitFor } from '@testing-library/react'
 import { describe, it, expect, beforeEach, vi } from 'vitest'
-import { ViewComplianceReportBrancher } from '../ViewComplianceReportBrancher'
+import { ComplianceReportViewSelector } from '../ComplianceReportViewSelector.jsx'
 import * as useComplianceReportsHook from '@/hooks/useComplianceReports'
 import * as useCurrentUserHook from '@/hooks/useCurrentUser'
 import { wrapper } from '@/tests/utils/wrapper'
@@ -71,7 +71,7 @@ describe('ViewComplianceReportBrancher', () => {
 
   it('renders loading when user is loading', async () => {
     setupMocks({ isCurrentUserLoading: true })
-    render(<ViewComplianceReportBrancher />, { wrapper })
+    render(<ComplianceReportViewSelector />, { wrapper })
 
     await waitFor(() => {
       expect(screen.getByText('Loading...')).toBeInTheDocument()
@@ -80,7 +80,7 @@ describe('ViewComplianceReportBrancher', () => {
 
   it('renders loading when report is loading', async () => {
     setupMocks({ isReportLoading: true })
-    render(<ViewComplianceReportBrancher />, { wrapper })
+    render(<ComplianceReportViewSelector />, { wrapper })
 
     await waitFor(() => {
       expect(screen.getByText('Loading...')).toBeInTheDocument()
@@ -97,7 +97,7 @@ describe('ViewComplianceReportBrancher', () => {
       }
     })
 
-    render(<ViewComplianceReportBrancher />, { wrapper })
+    render(<ComplianceReportViewSelector />, { wrapper })
 
     await waitFor(() => {
       expect(screen.getByText('Legacy Report View')).toBeInTheDocument()
@@ -117,7 +117,7 @@ describe('ViewComplianceReportBrancher', () => {
       }
     })
 
-    render(<ViewComplianceReportBrancher />, { wrapper })
+    render(<ComplianceReportViewSelector />, { wrapper })
 
     await waitFor(() => {
       expect(screen.getByText('Edit Compliance Report')).toBeInTheDocument()
@@ -137,7 +137,7 @@ describe('ViewComplianceReportBrancher', () => {
       }
     })
 
-    render(<ViewComplianceReportBrancher />, { wrapper })
+    render(<ComplianceReportViewSelector />, { wrapper })
 
     await waitFor(() => {
       expect(screen.getByText('Edit Compliance Report')).toBeInTheDocument()