Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LCFS - Fuel code number #1303

Closed
6 tasks
airinggov opened this issue Nov 27, 2024 · 2 comments · Fixed by #1476 or #1519
Closed
6 tasks

LCFS - Fuel code number #1303

airinggov opened this issue Nov 27, 2024 · 2 comments · Fixed by #1476 or #1519
Assignees
Labels
Fuel Codes Medium Medium priority Story User story Tested :) Testing passed

Comments

@airinggov
Copy link
Collaborator

airinggov commented Nov 27, 2024

Description:
Currently, the functionality for assigning a new fuel code number works well when the form is loaded using the "New fuel code" button. The same functionality should be extended to when a user clicks the "Add row" and "Duplicate row" buttons.

Wireframe:
N/A (or attach a relevant wireframe if available).

Purpose and benefit to user:
This update ensures consistency in the behavior of the application across different entry points, reducing user confusion and enhancing the user experience by automating the assignment of new fuel codes in all relevant scenarios.

Acceptance Criteria:

  • When a user clicks the "Add row" button, the form should assign the next available fuel code number based on default prefix and updated if the prefix is updated from the dropdown list
  • When a user clicks the "Duplicate row" icon, the form should assign the next available fuel code number based on prefix that was duplicated and updated if the prefix is updated from the dropdown list
  • The process for assigning the fuel code number should mirror the existing functionality when using the "New fuel code" button.

Development Checklist:

  • Apply the same function (as New Fuel Code button action) to trigger when the "Add row" button is clicked based on default prefix (BCLCF) to insert next fuel code number.
  • Apply the same function (as New Fuel Code button action) to trigger when the "Duplicate row" icon is clicked based on default prefix (BCLCF) to insert next fuel code number.
  • Apply the same function (as New Fuel Code button action) to trigger when the user changes the Prefix selection.

Notes:

@airinggov
Copy link
Collaborator Author

Image

@hamed-valiollahi The fuel code number assigned after using the duplicate row function is not incrementing, even after interacting with the Prefix select it doesn't update.

Also the Duplicate row function put the new row above the existing record, it should be below.

@airinggov airinggov reopened this Dec 19, 2024
@hamed-valiollahi
Copy link
Collaborator

@airinggov Thank you, Al, for testing! It's weird, as it was working without the issues you mentioned. It's probably a conflict with other tickets. I'll fix this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fuel Codes Medium Medium priority Story User story Tested :) Testing passed
Projects
None yet
2 participants