Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Resolve fuel code assignment and field clearing issues - #1303, #1433 #1476

Merged

Conversation

hamed-valiollahi
Copy link
Collaborator

This PR ensures consistent fuel code assignment on Add/Duplicate row actions and prevents clearing of fields when the Prefix selection is changed.

Closes #1303, #1433

Copy link

github-actions bot commented Dec 17, 2024

Frontend Test Results

  1 files  ±0  116 suites  ±0   38s ⏱️ ±0s
390 tests ±0  370 ✅ ±0  20 💤 ±0  0 ❌ ±0 
392 runs  ±0  372 ✅ ±0  20 💤 ±0  0 ❌ ±0 

Results for commit 8d403e5. ± Comparison against base commit f3b404d.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Dec 17, 2024

Backend Test Results

498 tests  ±0   495 ✅ ±0   1m 51s ⏱️ ±0s
  1 suites ±0     0 💤 ±0 
  1 files   ±0     3 ❌ ±0 

For more details on these failures, see this check.

Results for commit 8d403e5. ± Comparison against base commit f3b404d.

♻️ This comment has been updated with latest results.

Copy link
Collaborator

@dhaselhan dhaselhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@hamed-valiollahi hamed-valiollahi merged commit 0f35a15 into release-0.2.0 Dec 18, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LCFS - Fuel code number
2 participants