-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LCFS-1280: Validation for Quantity Supplied #1335
LCFS-1280: Validation for Quantity Supplied #1335
Conversation
Backend Test Results493 tests ±0 490 ✅ ±0 1m 48s ⏱️ -2s For more details on these failures, see this check. Results for commit a14d1ec. ± Comparison against base commit 8edd0af. ♻️ This comment has been updated with latest results. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, I would just like to see a frontend test covering this 0 quantity state and that it shows the error correctly.
0290b58
to
ea5efa5
Compare
7602b3e
to
59b6b62
Compare
Let's get this merged, just need to fix the conflicts, otherwise looks good to go. |
85f723e
to
c4544a3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't want to add this validation across quantity fields, i think just focus on fuel_supply. If you hear differently from business area then let me know.
5c75487
to
8350dca
Compare
ce1737f
to
a14d1ec
Compare
PR related: #1312
Story