Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Default allocation agreement to 1 row on empty data #1368

Merged
merged 6 commits into from
Dec 10, 2024
Merged

Fix: Default allocation agreement to 1 row on empty data #1368

merged 6 commits into from
Dec 10, 2024

Conversation

AlexZorkin
Copy link
Collaborator

  • Added check for empty data and creates default row
  • Added test for addeditallocationagreement component

dhaselhan
dhaselhan approved these changes Dec 4, 2024
View reviewed changes
Copy link
Collaborator

@dhaselhan dhaselhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 6, 2024 •
edited
Loading

Backend Test Results

449 tests  ±0   449 ✅ ±0   1m 47s ⏱️ -1s
  1 suites ±0     0 💤 ±0 
  1 files   ±0     0 ❌ ±0 

Results for commit 0ce804f. ± Comparison against base commit 20e45d6.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 6, 2024 •
edited
Loading

Frontend Test Results

  1 files  ±0  116 suites  +1   37s ⏱️ ±0s
388 tests +3  368 ✅ +3  20 💤 ±0  0 ❌ ±0 
390 runs  +3  370 ✅ +3  20 💤 ±0  0 ❌ ±0 

Results for commit 0ce804f. ± Comparison against base commit 20e45d6.

♻️ This comment has been updated with latest results.

@dhaselhan dhaselhan mentioned this pull request Dec 9, 2024
Closed
@AlexZorkin AlexZorkin merged commit 7c77662 into release-0.2.0 Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhaselhan dhaselhan dhaselhan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AlexZorkin @dhaselhan @prv-proton