Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Load EER ratio even when end use is not defined #1377

Merged
merged 2 commits into from
Dec 11, 2024
Merged

fix: Load EER ratio even when end use is not defined #1377

merged 2 commits into from
Dec 11, 2024

Conversation

dhaselhan
Copy link
Collaborator

No description provided.

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 5, 2024 •
edited
Loading

Backend Test Results

493 tests  +44   493 ✅ +44   1m 45s ⏱️ ±0s
  1 suites ± 0     0 💤 ± 0 
  1 files   ± 0     0 ❌ ± 0 

Results for commit d562b13. ± Comparison against base commit 38279d5.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 5, 2024 •
edited
Loading

Frontend Test Results

  1 files  ±0  116 suites  ±0   37s ⏱️ -1s
388 tests ±0  368 ✅ ±0  20 💤 ±0  0 ❌ ±0 
390 runs  ±0  370 ✅ ±0  20 💤 ±0  0 ❌ ±0 

Results for commit d562b13. ± Comparison against base commit 38279d5.

♻️ This comment has been updated with latest results.

AlexZorkin
AlexZorkin requested changes Dec 6, 2024
View reviewed changes
Copy link
Collaborator

@AlexZorkin AlexZorkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but this seems like a good place to have some test coverage.

@dhaselhan dhaselhan force-pushed the fix/daniel-load-eer-in-all-cases-1318 branch from ef9d9ad to 038292e Compare December 6, 2024 19:36
@dhaselhan
Copy link
Collaborator Author

Looks good but this seems like a good place to have some test coverage.

Added lots of tests to the repo

@dhaselhan dhaselhan requested a review from AlexZorkin December 6, 2024 19:37
AlexZorkin
AlexZorkin approved these changes Dec 11, 2024
View reviewed changes
Copy link
Collaborator

@AlexZorkin AlexZorkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@dhaselhan dhaselhan force-pushed the fix/daniel-load-eer-in-all-cases-1318 branch from 1e53b5f to d562b13 Compare December 11, 2024 18:16
@dhaselhan dhaselhan merged commit a46a998 into release-0.2.0 Dec 11, 2024
9 checks passed
@dhaselhan dhaselhan deleted the fix/daniel-load-eer-in-all-cases-1318 branch December 11, 2024 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexZorkin AlexZorkin AlexZorkin approved these changes

@prv-proton prv-proton Awaiting requested review from prv-proton

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dhaselhan @AlexZorkin