Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LCFS-1255 Add organization name to FSE identification grid input and view table #1380

Merged
merged 3 commits into from
Dec 11, 2024

Conversation

areyeslo
Copy link
Collaborator

@areyeslo areyeslo commented Dec 5, 2024

Add organization madatory field to FSE grid and view table.
The new autocomplete field provides the list of external organizations related to the compliance report's organization

Add new final supply equipment (FSE):
image

Report Details:
image

Story

Copy link

github-actions bot commented Dec 5, 2024

Backend Test Results

493 tests  ±0   493 ✅ ±0   1m 45s ⏱️ -1s
  1 suites ±0     0 💤 ±0 
  1 files   ±0     0 ❌ ±0 

Results for commit 04f1b78. ± Comparison against base commit a46a998.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Dec 5, 2024

Frontend Test Results

  1 files  ±0  116 suites  ±0   37s ⏱️ ±0s
388 tests ±0  368 ✅ ±0  20 💤 ±0  0 ❌ ±0 
390 runs  ±0  370 ✅ ±0  20 💤 ±0  0 ❌ ±0 

Results for commit 04f1b78. ± Comparison against base commit a46a998.

♻️ This comment has been updated with latest results.

@areyeslo areyeslo force-pushed the LCFS-1255-AddOrganizationNameFSE branch from 21c4ac6 to 0e0452e Compare December 5, 2024 21:30
Copy link
Collaborator

@AlexZorkin AlexZorkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but lets be more specific with the variable names to reduce confusion between our organization model.

@areyeslo areyeslo force-pushed the LCFS-1255-AddOrganizationNameFSE branch from bf87c6e to fa63911 Compare December 9, 2024 17:47
@areyeslo areyeslo requested a review from AlexZorkin December 9, 2024 17:59
@areyeslo areyeslo force-pushed the LCFS-1255-AddOrganizationNameFSE branch from e15fbe6 to 81857ea Compare December 11, 2024 18:58
Copy link
Collaborator

@AlexZorkin AlexZorkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good 👍

@areyeslo areyeslo merged commit 52407c7 into release-0.2.0 Dec 11, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants