Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Allow negative symbol in transaction amount input #1405

Merged
merged 2 commits into from
Dec 10, 2024
Merged

fix: Allow negative symbol in transaction amount input #1405

merged 2 commits into from
Dec 10, 2024

Conversation

dhaselhan
Copy link
Collaborator

No description provided.

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 9, 2024 •
edited
Loading

Backend Test Results

449 tests  ±0   449 ✅ ±0   1m 48s ⏱️ +2s
  1 suites ±0     0 💤 ±0 
  1 files   ±0     0 ❌ ±0 

Results for commit 4db9dc3. ± Comparison against base commit f437eec.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 9, 2024 •
edited
Loading

Frontend Test Results

  1 files  ±0  115 suites  ±0   37s ⏱️ ±0s
385 tests ±0  365 ✅ ±0  20 💤 ±0  0 ❌ ±0 
387 runs  ±0  367 ✅ ±0  20 💤 ±0  0 ❌ ±0 

Results for commit 4db9dc3. ± Comparison against base commit f437eec.

♻️ This comment has been updated with latest results.

areyeslo
areyeslo approved these changes Dec 10, 2024
View reviewed changes
Copy link
Collaborator

@areyeslo areyeslo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just need to rebase.

@dhaselhan dhaselhan merged commit 9d09d69 into release-0.2.0 Dec 10, 2024
1 check passed
@dhaselhan dhaselhan deleted the fix/daniel-allow-negative-symbol-1388 branch December 10, 2024 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@areyeslo areyeslo areyeslo approved these changes

@hamed-valiollahi hamed-valiollahi Awaiting requested review from hamed-valiollahi

@AlexZorkin AlexZorkin Awaiting requested review from AlexZorkin

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dhaselhan @areyeslo