Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Bypass auth for health check #1409

Merged
merged 3 commits into from
Dec 10, 2024

Conversation

dhaselhan
Copy link
Collaborator

  • Add code to bypass auth check for health endpoint

* Add code to bypass auth check for health endpoint
Copy link

github-actions bot commented Dec 9, 2024

Backend Test Results

449 tests  ±0   449 ✅ ±0   1m 43s ⏱️ -9s
  1 suites ±0     0 💤 ±0 
  1 files   ±0     0 ❌ ±0 

Results for commit 2f15131. ± Comparison against base commit a002911.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Dec 9, 2024

Frontend Test Results

  1 files  ±0  115 suites  ±0   37s ⏱️ -1s
385 tests ±0  365 ✅ ±0  20 💤 ±0  0 ❌ ±0 
387 runs  ±0  367 ✅ ±0  20 💤 ±0  0 ❌ ±0 

Results for commit 2f15131. ± Comparison against base commit a002911.

♻️ This comment has been updated with latest results.

Copy link
Collaborator

@AlexZorkin AlexZorkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Collaborator

@prv-proton prv-proton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. But just a suggestion, can we have health check report something like below to get the status of connections?

{ "status": "DOWN", "components": { "database": { "status": "UP", "details": { "response_time_ms": 10 } }, "cache": { "status": "UP", "details": { "cache_hits": 150, "cache_misses": 10 } }, } }

@dhaselhan
Copy link
Collaborator Author

Looks good to me. But just a suggestion, can we have health check report something like below to get the status of connections?

{ "status": "DOWN", "components": { "database": { "status": "UP", "details": { "response_time_ms": 10 } }, "cache": { "status": "UP", "details": { "cache_hits": 150, "cache_misses": 10 } }, } }

This endpoint is for Openshift where its just used to ping to check for uptime. If we want a more in depth health check that reports to some other system I am good with that but it should be its own endpoint.

@dhaselhan dhaselhan merged commit e3b3a67 into release-0.2.0 Dec 10, 2024
9 checks passed
@dhaselhan dhaselhan deleted the feat/daniel-expose-health-1408 branch December 10, 2024 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants