-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Bypass auth for health check #1409
Conversation
dhaselhan
commented
Dec 9, 2024
- Add code to bypass auth check for health endpoint
* Add code to bypass auth check for health endpoint
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. But just a suggestion, can we have health check report something like below to get the status of connections?
{ "status": "DOWN", "components": { "database": { "status": "UP", "details": { "response_time_ms": 10 } }, "cache": { "status": "UP", "details": { "cache_hits": 150, "cache_misses": 10 } }, } }
This endpoint is for Openshift where its just used to ping to check for uptime. If we want a more in depth health check that reports to some other system I am good with that but it should be its own endpoint. |