Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Add $ sign to Fair Market Value per Credit field - #1412 #1444

Merged

Conversation

hamed-valiollahi
Copy link
Collaborator

This PR adds a "$" sign to the Fair Market Value per Credit field in the Transfer Input page.

Closes #1412

Copy link

github-actions bot commented Dec 12, 2024

Frontend Test Results

  1 files  ±0  116 suites  ±0   38s ⏱️ -1s
390 tests ±0  370 ✅ ±0  20 💤 ±0  0 ❌ ±0 
392 runs  ±0  372 ✅ ±0  20 💤 ±0  0 ❌ ±0 

Results for commit 7fc8e8e. ± Comparison against base commit 390f6f1.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Dec 12, 2024

Backend Test Results

493 tests  ±0   491 ✅ ±0   1m 47s ⏱️ -3s
  1 suites ±0     0 💤 ±0 
  1 files   ±0     2 ❌ ±0 

For more details on these failures, see this check.

Results for commit 7fc8e8e. ± Comparison against base commit 390f6f1.

♻️ This comment has been updated with latest results.

Copy link
Collaborator

@prv-proton prv-proton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@hamed-valiollahi
Copy link
Collaborator Author

Looks good.

Thanks, Prashanth, for the code review!

@hamed-valiollahi hamed-valiollahi merged commit 1f15bd6 into release-0.2.0 Dec 12, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LCFS - Add $ symbol to value per credit to transfer input page
2 participants