Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LCFS-1399: Autopopulating units field depending on the Fuel Type selected #1445

Merged
merged 3 commits into from
Dec 12, 2024

Conversation

areyeslo
Copy link
Collaborator

The "Unit" field should auto-populate with a default unit that corresponds to the selected fuel type.

image

Copy link

github-actions bot commented Dec 12, 2024

Frontend Test Results

  1 files  ±0  116 suites  ±0   36s ⏱️ -2s
390 tests ±0  370 ✅ ±0  20 💤 ±0  0 ❌ ±0 
392 runs  ±0  372 ✅ ±0  20 💤 ±0  0 ❌ ±0 

Results for commit d08d44e. ± Comparison against base commit cbc1888.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Dec 12, 2024

Backend Test Results

493 tests  ±0   491 ✅ ±0   1m 48s ⏱️ ±0s
  1 suites ±0     0 💤 ±0 
  1 files   ±0     2 ❌ ±0 

For more details on these failures, see this check.

Results for commit d08d44e. ± Comparison against base commit cbc1888.

♻️ This comment has been updated with latest results.

Copy link
Collaborator

@hamed-valiollahi hamed-valiollahi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! I tested it locally as well. Please review my comments. Thank you!

frontend/src/views/OtherUses/_schema.jsx Outdated Show resolved Hide resolved
frontend/src/views/OtherUses/_schema.jsx Outdated Show resolved Hide resolved
@areyeslo
Copy link
Collaborator Author

Thanks for taking the time to test locally.

@areyeslo areyeslo merged commit 390f6f1 into release-0.2.0 Dec 12, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants