Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: LCFS - Reformat In-App Notifications tied to Email Subscriptions into AG Grid #1464

Merged
merged 13 commits into from
Dec 17, 2024
Merged

Feat: LCFS - Reformat In-App Notifications tied to Email Subscriptions into AG Grid #1464

merged 13 commits into from
Dec 17, 2024

Conversation

prv-proton
Copy link
Collaborator

@prv-proton prv-proton commented Dec 16, 2024 •
edited
Loading

#1135

  • migration, added transaction_id and type columns to NotificationMessage table.
  • update and fixed to test cases.
  • create app notifications when statuses change in InitiativeAgreement, transfer and compliance reports.
  • Below UI for notifications page
    image

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 16, 2024 •
edited
Loading

Frontend Test Results

  1 files  ±0  116 suites  ±0   38s ⏱️ ±0s
390 tests ±0  370 ✅ ±0  20 💤 ±0  0 ❌ ±0 
392 runs  ±0  372 ✅ ±0  20 💤 ±0  0 ❌ ±0 

Results for commit d7e3adb. ± Comparison against base commit 4dab704.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 16, 2024 •
edited
Loading

Backend Test Results

498 tests  +5   490 ✅ ±0   1m 51s ⏱️ ±0s
  1 suites ±0     0 💤 ±0 
  1 files   ±0     8 ❌ +5 

For more details on these failures, see this check.

Results for commit d7e3adb. ± Comparison against base commit 4dab704.

♻️ This comment has been updated with latest results.

@prv-proton prv-proton marked this pull request as draft December 16, 2024 18:55
@prv-proton prv-proton marked this pull request as ready for review December 17, 2024 13:20
dhaselhan
dhaselhan requested changes Dec 17, 2024
View reviewed changes
backend/lcfs/db/models/notification/NotificationMessage.py Outdated Show resolved Hide resolved
backend/lcfs/web/api/compliance_report/update_service.py Outdated Show resolved Hide resolved
backend/lcfs/web/api/compliance_report/update_service.py Outdated Show resolved Hide resolved
backend/lcfs/web/api/initiative_agreement/services.py Outdated Show resolved Hide resolved
backend/lcfs/web/api/notification/repo.py Outdated Show resolved Hide resolved
backend/lcfs/web/api/notification/schema.py Outdated Show resolved Hide resolved
backend/lcfs/web/api/notification/schema.py Outdated Show resolved Hide resolved
backend/lcfs/web/api/transfer/services.py Outdated Show resolved Hide resolved
dhaselhan
dhaselhan approved these changes Dec 17, 2024
View reviewed changes
Copy link
Collaborator

@dhaselhan dhaselhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@prv-proton prv-proton merged commit 5b29999 into release-0.2.0 Dec 17, 2024
1 check passed
@prv-proton prv-proton deleted the feat/prashanth-inapp-notfn-1135 branch December 17, 2024 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhaselhan dhaselhan dhaselhan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@prv-proton @dhaselhan