Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LCFS-1426: Upload file attachements compliance reports for Analyst user #1471

Merged

Conversation

areyeslo
Copy link
Collaborator

Extend the logic of Supporting Documents to allow Analyst to attach Supporting Documents as long as the compliance report status is submitted or assessed. Supporting documents section is visible at all times.

New Logic:

  • BCeID user can attach supporting documents to a compliance report under draft:
image
  • Analyst user can check the submitted report and attach supporting documents:
image
  • Under submitted report, BCeID user can see the supporting documents section, but not modify docs in the section:
image

Copy link

github-actions bot commented Dec 17, 2024

Frontend Test Results

  1 files  ±0  119 suites  ±0   39s ⏱️ -1s
411 tests ±0  391 ✅ ±0  20 💤 ±0  0 ❌ ±0 
413 runs  ±0  393 ✅ ±0  20 💤 ±0  0 ❌ ±0 

Results for commit faae96e. ± Comparison against base commit 15ff76b.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Dec 17, 2024

Backend Test Results

502 tests  +502   502 ✅ +502   2m 1s ⏱️ + 2m 1s
  1 suites +  1     0 💤 ±  0 
  1 files   +  1     0 ❌ ±  0 

Results for commit faae96e. ± Comparison against base commit 15ff76b.

♻️ This comment has been updated with latest results.

@areyeslo areyeslo changed the title LCFS-1426: Upload file attachements compliance reports in submitted/assessed status LCFS-1426: Upload file attachements compliance reports for Analyst user Dec 17, 2024
@prv-proton prv-proton self-requested a review December 17, 2024 17:55
Copy link
Collaborator

@prv-proton prv-proton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you please validate the endpoint for any security threats.

@areyeslo areyeslo force-pushed the LCFS-1426-UploadFileAttachements-ComplianceReports branch from eb01c04 to 5f94d0a Compare December 17, 2024 22:47
@areyeslo areyeslo requested a review from prv-proton December 17, 2024 22:54
Copy link
Collaborator

@prv-proton prv-proton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not meeting all the acceptance criteria.

@areyeslo areyeslo force-pushed the LCFS-1426-UploadFileAttachements-ComplianceReports branch from 1683355 to 042346d Compare December 18, 2024 20:28
@areyeslo areyeslo requested a review from prv-proton December 18, 2024 22:16
Copy link
Collaborator

@prv-proton prv-proton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@areyeslo areyeslo force-pushed the LCFS-1426-UploadFileAttachements-ComplianceReports branch from 275e8e1 to faae96e Compare December 20, 2024 17:27
@areyeslo areyeslo merged commit 7314769 into release-0.2.0 Dec 20, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants