Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LCFS-1446: Fuel code Feedstock transport mode & Finished fuel transport mode not displaying values #1474

Conversation

areyeslo
Copy link
Collaborator

  • The _schema for AddEditFuelCode is expecting an array of strings.
  • Added transformation for transport modes

Open an existing fuel code/ create a fuel code and confirm the transport modes are included after creation:
image

Copy link

github-actions bot commented Dec 17, 2024

Frontend Test Results

  1 files  ±0  116 suites  ±0   39s ⏱️ -1s
390 tests ±0  370 ✅ ±0  20 💤 ±0  0 ❌ ±0 
392 runs  ±0  372 ✅ ±0  20 💤 ±0  0 ❌ ±0 

Results for commit fd1198c. ± Comparison against base commit 7d397b3.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Dec 17, 2024

Backend Test Results

501 tests  ±0   501 ✅ ±0   1m 52s ⏱️ -2s
  1 suites ±0     0 💤 ±0 
  1 files   ±0     0 ❌ ±0 

Results for commit fd1198c. ± Comparison against base commit 7d397b3.

♻️ This comment has been updated with latest results.

Copy link
Collaborator

@kevin-hashimoto kevin-hashimoto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@areyeslo areyeslo force-pushed the LCFS-1446-FuelCodeFeedstockTransportMode-FnishedFuelTransportModeNotDisplayed branch from 6d327d8 to fd1198c Compare December 18, 2024 16:28
@areyeslo areyeslo merged commit 3187c52 into release-0.2.0 Dec 18, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants