Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug fix for ag-grid checkbox #1475

Merged
merged 3 commits into from
Dec 17, 2024

Conversation

prv-proton
Copy link
Collaborator

@prv-proton prv-proton commented Dec 17, 2024

updating code as per new migration: https://www.ag-grid.com/react-data-grid/row-selection/

@prv-proton prv-proton requested a review from areyeslo December 17, 2024 20:37
Copy link

github-actions bot commented Dec 17, 2024

Frontend Test Results

  1 files  ±0  116 suites  ±0   39s ⏱️ -1s
390 tests ±0  370 ✅ ±0  20 💤 ±0  0 ❌ ±0 
392 runs  ±0  372 ✅ ±0  20 💤 ±0  0 ❌ ±0 

Results for commit d8fb658. ± Comparison against base commit 5b29999.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Dec 17, 2024

Backend Test Results

498 tests  ±0   495 ✅ +5   1m 55s ⏱️ +5s
  1 suites ±0     0 💤 ±0 
  1 files   ±0     3 ❌  - 5 

For more details on these failures, see this check.

Results for commit d8fb658. ± Comparison against base commit 5b29999.

♻️ This comment has been updated with latest results.

Copy link
Collaborator

@areyeslo areyeslo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@prv-proton prv-proton merged commit 9e10bc6 into release-0.2.0 Dec 17, 2024
1 check passed
@prv-proton prv-proton deleted the fix/prashshanth-checkbox-notfn-bug branch December 17, 2024 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants