Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add validation rule for other_fuel_type #1477

Merged
merged 2 commits into from
Dec 18, 2024

Conversation

dhaselhan
Copy link
Collaborator

  • Validate that if the fuel type is unrecognized we require other to be populated
  • Add new tests
  • Fix broken tests in develop

* Validate that if the fuel type is unrecognized we require other to be populated
* Add new tests
* Fix broken tests in develop
Copy link

github-actions bot commented Dec 17, 2024

Frontend Test Results

  1 files  ±0  116 suites  ±0   39s ⏱️ -1s
390 tests ±0  370 ✅ ±0  20 💤 ±0  0 ❌ ±0 
392 runs  ±0  372 ✅ ±0  20 💤 ±0  0 ❌ ±0 

Results for commit 2a2cd6b. ± Comparison against base commit 0f35a15.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Dec 17, 2024

Backend Test Results

501 tests  +3   501 ✅ +6   1m 51s ⏱️ -1s
  1 suites ±0     0 💤 ±0 
  1 files   ±0     0 ❌  - 3 

Results for commit 2a2cd6b. ± Comparison against base commit 0f35a15.

♻️ This comment has been updated with latest results.

Copy link
Collaborator

@hamed-valiollahi hamed-valiollahi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

@dhaselhan dhaselhan merged commit 04a7a3b into release-0.2.0 Dec 18, 2024
11 checks passed
@dhaselhan dhaselhan deleted the feat/daniel-requir-other-1455 branch December 18, 2024 00:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants