Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: toast on 400+ errors #1478

Merged
merged 2 commits into from
Dec 18, 2024
Merged

feat: toast on 400+ errors #1478

merged 2 commits into from
Dec 18, 2024

Conversation

kevin-hashimoto
Copy link
Collaborator

@kevin-hashimoto kevin-hashimoto commented Dec 17, 2024

note: mui v6 has their own implementation via their toolpad package. would be good to look into later when/if upgrading mui to v6.

Copy link

github-actions bot commented Dec 17, 2024

Frontend Test Results

  1 files  ±0  116 suites  ±0   38s ⏱️ -1s
390 tests ±0  370 ✅ ±0  20 💤 ±0  0 ❌ ±0 
392 runs  ±0  372 ✅ ±0  20 💤 ±0  0 ❌ ±0 

Results for commit 1ee6405. ± Comparison against base commit 04a7a3b.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Dec 17, 2024

Backend Test Results

501 tests  ±0   501 ✅ ±0   1m 49s ⏱️ -1s
  1 suites ±0     0 💤 ±0 
  1 files   ±0     0 ❌ ±0 

Results for commit 1ee6405. ± Comparison against base commit 04a7a3b.

♻️ This comment has been updated with latest results.

Copy link
Collaborator

@dhaselhan dhaselhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Definitely agree that Material V5 Snackbar is lacking an imperative interface. Nice work.

@kevin-hashimoto kevin-hashimoto merged commit d425239 into release-0.2.0 Dec 18, 2024
11 checks passed
@kevin-hashimoto kevin-hashimoto deleted the feat/kevin-1441 branch December 18, 2024 01:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LCFS - Show red toast on network errors
2 participants