fix: Round all the things #1481
Closed
+642
−50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
dhaselhan
commented
Dec 17, 2024
dhaselhan
commented
- Convert all column in summary that store quantity or units to integer as they should never have decimals
- Update summary calculation to round unit penalties
* Convert all column in summary that store quantity or units to integer as they should never have decimals * Update summary calculation to round unit penalties
Backend Test Results498 tests ±0 495 ✅ ±0 1m 50s ⏱️ -2s For more details on these failures, see this check. Results for commit 767678a. ± Comparison against base commit b3a70ae. |
AlexZorkin
requested changes
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.