Fix: Relocate 'Comments to the Director' widget - #1454 #1483
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Backend Test Results498 tests ±0 495 ✅ ±0 1m 52s ⏱️ -1s For more details on these failures, see this check. Results for commit 3bc241e. ± Comparison against base commit deab8ae. ♻️ This comment has been updated with latest results. |
dhaselhan
reviewed
Dec 17, 2024
| @@ -444,6 +445,22 @@ export const AddEditViewTransfer = () => { | |||
| </> | |||
| )} | |||
|
|
|||
| {/* Internal Comments */} | |||
| {!editorMode && ( | |||
| <> | |||
There was a problem hiding this comment.
suggestion: I don't think you need the wrapper component <> since you are returning a single component.
There was a problem hiding this comment.
Good catch! Removed the unnecessary <></> wrapper. Thanks!
…s://github.com/bcgov/lcfs into fix/hamed-relocate-comments-widget-1454
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the position of the "Comments to the Director" widget as specified in the wireframe.
Closes #1454