-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Sorting & Display of FSE #1484
Conversation
dhaselhan
commented
Dec 17, 2024
- Sort both paginated and non paginated by create date asc to match other schedules
- Fix kWH usage column to use nice number formatter without decimals
* Sort both paginated and non paginated by create date asc to match other schedules * Fix kWH usage column to use nice number formatter without decimals
742570a
to
ac1bc2d
Compare
Frontend Test Results 1 files ±0 116 suites ±0 39s ⏱️ -1s For more details on these failures, see this check. Results for commit ac49b23. ± Comparison against base commit 5fa0ddc. ♻️ This comment has been updated with latest results. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
As a suggestion, would sorting by id
be more efficient here since integer comparisons are typically faster than timestamp comparisons like created_date
?
Depending on how ETL works this may or may not be true. ETL may insert records with a higher ID but a copied Create Date from TFRS. Ill ask Alex. |
Thank you! In case there is significant improvement, we can also update the ETL to ensure the correct order of fetching data. Also, I noticed that there are a few places in the database where the tables don’t have proper indexing. It would be great if we could check and address that as well. |
Talked to Alex, he mentioned we are transferring Create Date so we can use that. |
Nice, thanks, Daniel! |