Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Round non-currency numbers in Summary Table #1504

Merged
merged 3 commits into from
Dec 20, 2024

Conversation

dhaselhan
Copy link
Collaborator

  • Update number formatter to take max decimals
  • Set max decimals to 0 on Summary Page

@dhaselhan dhaselhan requested a review from AlexZorkin December 18, 2024 22:47
Copy link

github-actions bot commented Dec 18, 2024

Frontend Test Results

  1 files  ±0  119 suites  ±0   40s ⏱️ ±0s
411 tests ±0  391 ✅ ±0  20 💤 ±0  0 ❌ ±0 
413 runs  ±0  393 ✅ ±0  20 💤 ±0  0 ❌ ±0 

Results for commit eca1dea. ± Comparison against base commit 7314769.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Dec 18, 2024

Backend Test Results

502 tests  ±0   502 ✅ ±0   1m 50s ⏱️ -4s
  1 suites ±0     0 💤 ±0 
  1 files   ±0     0 ❌ ±0 

Results for commit eca1dea. ± Comparison against base commit 7314769.

♻️ This comment has been updated with latest results.

* Update number formatter to take max decimals
* Set max decimals to 0 on Summary Page
@dhaselhan dhaselhan force-pushed the fix/daniel-round-summary-numbers-1462 branch from b9b90fe to 0bbea98 Compare December 18, 2024 23:24
Copy link
Collaborator

@AlexZorkin AlexZorkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rounding is fun.

@dhaselhan dhaselhan merged commit dfb5501 into release-0.2.0 Dec 20, 2024
1 check passed
@dhaselhan dhaselhan deleted the fix/daniel-round-summary-numbers-1462 branch December 20, 2024 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants