Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Disable navigating unless report is draft #1505

Merged
merged 1 commit into from
Dec 18, 2024

Conversation

dhaselhan
Copy link
Collaborator

  • Only execute navigate if report is in Draft status to prevent draft clicks from going to edit

* Only execute navigate if report is in Draft status to prevent draft clicks from going to edit
Copy link

Frontend Test Results

  1 files  ±0  116 suites  ±0   39s ⏱️ ±0s
390 tests ±0  370 ✅ ±0  20 💤 ±0  0 ❌ ±0 
392 runs  ±0  372 ✅ ±0  20 💤 ±0  0 ❌ ±0 

Results for commit a464e91. ± Comparison against base commit cb5f7aa.

Copy link
Collaborator

@kevin-hashimoto kevin-hashimoto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻 clicking on rows outside of draft status no longer go to the edit page

Copy link

Backend Test Results

502 tests  ±0   502 ✅ ±0   1m 51s ⏱️ ±0s
  1 suites ±0     0 💤 ±0 
  1 files   ±0     0 ❌ ±0 

Results for commit a464e91. ± Comparison against base commit cb5f7aa.

@dhaselhan dhaselhan merged commit 09dd16a into release-0.2.0 Dec 18, 2024
1 check passed
@dhaselhan dhaselhan deleted the fix/daniel-block-navigation-1473 branch December 18, 2024 23:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants