Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Correct Pagination for User Table Filter - 1430 #1513

Merged
merged 3 commits into from
Dec 20, 2024

Conversation

hamed-valiollahi
Copy link
Collaborator

This PR fixes the pagination to display the correct count of filtered items on the User Table.

Closes #1430

Copy link

github-actions bot commented Dec 19, 2024

Frontend Test Results

  1 files  ±0  119 suites  ±0   41s ⏱️ -1s
411 tests ±0  391 ✅ ±0  20 💤 ±0  0 ❌ ±0 
413 runs  ±0  393 ✅ ±0  20 💤 ±0  0 ❌ ±0 

Results for commit 5b9ac63. ± Comparison against base commit a98abf4.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Dec 19, 2024

Backend Test Results

502 tests  ±0   502 ✅ ±0   1m 52s ⏱️ ±0s
  1 suites ±0     0 💤 ±0 
  1 files   ±0     0 ❌ ±0 

Results for commit 5b9ac63. ± Comparison against base commit a98abf4.

♻️ This comment has been updated with latest results.

@hamed-valiollahi
Copy link
Collaborator Author

@areyeslo Thank you for the code review! The requested change has been applied.

Copy link
Collaborator

@areyeslo areyeslo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hamed-valiollahi hamed-valiollahi merged commit 30d75c4 into release-0.2.0 Dec 20, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LCFS BUG - Pagination incorrect for User Table
2 participants