Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LCFS-1515: Fuel supply, Other, Jet fuel category #1521

Merged
merged 3 commits into from
Dec 20, 2024

Conversation

areyeslo
Copy link
Collaborator

@areyeslo areyeslo commented Dec 19, 2024

When selecting a Fuel Type that has multiple Fuel Categories, the first element of the category is selected. However, this can cause that user submits data that did not intend to include.

With the change the Fuel Category is cleared when there are multiple elements.

image

Story

Copy link

github-actions bot commented Dec 19, 2024

Frontend Test Results

  1 files  ±0  119 suites  ±0   41s ⏱️ -1s
411 tests ±0  391 ✅ ±0  20 💤 ±0  0 ❌ ±0 
413 runs  ±0  393 ✅ ±0  20 💤 ±0  0 ❌ ±0 

Results for commit 8174d52. ± Comparison against base commit dfb5501.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Dec 19, 2024

Backend Test Results

502 tests  ±0   502 ✅ ±0   1m 55s ⏱️ +6s
  1 suites ±0     0 💤 ±0 
  1 files   ±0     0 ❌ ±0 

Results for commit 8174d52. ± Comparison against base commit dfb5501.

♻️ This comment has been updated with latest results.

@areyeslo areyeslo force-pushed the LCFS-1515-FuelSupplyOtherJetFuelCategory branch from 151dfd2 to 0c147ec Compare December 20, 2024 22:04
@areyeslo areyeslo requested a review from dhaselhan December 20, 2024 22:11
@areyeslo areyeslo force-pushed the LCFS-1515-FuelSupplyOtherJetFuelCategory branch from 0c147ec to eace15c Compare December 20, 2024 22:19
@areyeslo areyeslo requested a review from dhaselhan December 20, 2024 23:07
Copy link
Collaborator

@dhaselhan dhaselhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@areyeslo areyeslo merged commit 882242b into release-0.2.0 Dec 20, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants