-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LCFS-1515: Fuel supply, Other, Jet fuel category #1521
Merged
areyeslo
merged 3 commits into
release-0.2.0
from
LCFS-1515-FuelSupplyOtherJetFuelCategory
Dec 20, 2024
Merged
LCFS-1515: Fuel supply, Other, Jet fuel category #1521
areyeslo
merged 3 commits into
release-0.2.0
from
LCFS-1515-FuelSupplyOtherJetFuelCategory
Dec 20, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhaselhan
reviewed
Dec 20, 2024
dhaselhan
reviewed
Dec 20, 2024
areyeslo
force-pushed
the
LCFS-1515-FuelSupplyOtherJetFuelCategory
branch
from
December 20, 2024 22:04
151dfd2
to
0c147ec
Compare
areyeslo
force-pushed
the
LCFS-1515-FuelSupplyOtherJetFuelCategory
branch
from
December 20, 2024 22:19
0c147ec
to
eace15c
Compare
dhaselhan
requested changes
Dec 20, 2024
dhaselhan
approved these changes
Dec 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When selecting a
Fuel Type
that has multipleFuel Categories
, the first element of the category is selected. However, this can cause that user submits data that did not intend to include.With the change the
Fuel Category
is cleared when there are multiple elements.Story