Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: LCFS - Fix ETL Role Mapping Between TFRS and LCFS #1594 #1600

Merged
merged 3 commits into from
Jan 4, 2025
Merged

Fix: LCFS - Fix ETL Role Mapping Between TFRS and LCFS #1594 #1600

merged 3 commits into from
Jan 4, 2025

Conversation

prv-proton
Copy link
Collaborator

Fix #1594

@prv-proton prv-proton marked this pull request as draft January 3, 2025 22:15
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 3, 2025 •
edited
Loading

Frontend Test Results

  1 files  ±0  121 suites  ±0   42s ⏱️ -1s
419 tests ±0  399 ✅ ±0  20 💤 ±0  0 ❌ ±0 
421 runs  ±0  401 ✅ ±0  20 💤 ±0  0 ❌ ±0 

Results for commit c34a898. ± Comparison against base commit 1d72287.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 3, 2025 •
edited
Loading

Backend Test Results

503 tests  ±0   503 ✅ ±0   1m 41s ⏱️ -1s
  1 suites ±0     0 💤 ±0 
  1 files   ±0     0 ❌ ±0 

Results for commit c34a898. ± Comparison against base commit 1d72287.

♻️ This comment has been updated with latest results.

@prv-proton prv-proton marked this pull request as ready for review January 3, 2025 22:20
@prv-proton prv-proton requested a review from AlexZorkin January 3, 2025 22:20
AlexZorkin
AlexZorkin approved these changes Jan 3, 2025
View reviewed changes
Copy link
Collaborator

@AlexZorkin AlexZorkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for figuring this logic out 👍

@prv-proton prv-proton merged commit 26b0bbb into release-0.2.0 Jan 4, 2025
1 check passed
@prv-proton prv-proton deleted the fix/prashanth-etl-role-map-1594 branch January 4, 2025 00:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexZorkin AlexZorkin AlexZorkin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

LCFS - Fix ETL Role Mapping Between TFRS and LCFS
2 participants
@prv-proton @AlexZorkin