Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Legacy Fuels #1622

Merged
merged 4 commits into from
Jan 9, 2025
Merged

Conversation

dhaselhan
Copy link
Collaborator

  • Migrate over legacy Fuel Types from TFRS and set is_legacy flag.

* Migrate over legacy Fuel Types from TFRS and set is_legacy flag.
@dhaselhan dhaselhan requested a review from AlexZorkin January 7, 2025 23:03
Copy link

github-actions bot commented Jan 7, 2025

Frontend Test Results

  1 files  ±0  121 suites  ±0   43s ⏱️ +2s
416 tests ±0  396 ✅ ±0  20 💤 ±0  0 ❌ ±0 
418 runs  ±0  398 ✅ ±0  20 💤 ±0  0 ❌ ±0 

Results for commit bbbca81. ± Comparison against base commit 50991f7.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Jan 7, 2025

Backend Test Results

503 tests  ±0   503 ✅ ±0   1m 47s ⏱️ +2s
  1 suites ±0     0 💤 ±0 
  1 files   ±0     0 ❌ ±0 

Results for commit bbbca81. ± Comparison against base commit 50991f7.

♻️ This comment has been updated with latest results.

Copy link
Collaborator

@AlexZorkin AlexZorkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is missing all the other legacy fuel types. We need to add all fuel types from TFRS even if they are duplicates because we need to associate the legacy energy density, eer values. They will be differentiated by the is_legacy flag.

Copy link
Collaborator

@AlexZorkin AlexZorkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@dhaselhan dhaselhan merged commit 7d4134f into release-0.2.0 Jan 9, 2025
11 checks passed
@dhaselhan dhaselhan deleted the feat/daniel-legacy-fuel-types-1551 branch January 9, 2025 23:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants