Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LCFS-1659: Incorrect fuel type list in Fuels for other use #1743

Merged

Conversation

areyeslo
Copy link
Collaborator

A previous PR was created to show the requested fuel types. However, Renewable naphtha is not included because its fuel code is expired.

This PR includes fuel types such as Renewable naphtha with its Default carbon intensity:
image

Copy link

github-actions bot commented Jan 18, 2025

Frontend Test Results

  1 files  ±0  125 suites  ±0   47s ⏱️ -1s
436 tests ±0  416 ✅ ±0  20 💤 ±0  0 ❌ ±0 
438 runs  ±0  418 ✅ ±0  20 💤 ±0  0 ❌ ±0 

Results for commit a7b36c2. ± Comparison against base commit 80948da.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Jan 18, 2025

Backend Test Results

517 tests  +2   517 ✅ +2   1m 50s ⏱️ +3s
  1 suites ±0     0 💤 ±0 
  1 files   ±0     0 ❌ ±0 

Results for commit a7b36c2. ± Comparison against base commit 80948da.

♻️ This comment has been updated with latest results.

Copy link
Collaborator

@AlexZorkin AlexZorkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, can we add a test or two to the test_other_uses_repo.py file just to cover this new logic.

@areyeslo areyeslo requested a review from AlexZorkin January 22, 2025 22:02
Copy link
Collaborator

@AlexZorkin AlexZorkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the pytests 👍

@areyeslo areyeslo merged commit 3014111 into release-0.2.0 Jan 23, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants