Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: #1675 (b) Temporary fix FAM search IDIR user scenario by switching to 'idir-account-detail` new IDIM-proxy endpoint. #1676

Merged
merged 2 commits into from
Nov 27, 2024
Merged

fix: #1675 (b) Temporary fix FAM search IDIR user scenario by switching to 'idir-account-detail` new IDIM-proxy endpoint. #1676

merged 2 commits into from
Nov 27, 2024

Conversation

ianliuwk1019
Copy link
Collaborator

@ianliuwk1019 ianliuwk1019 commented Nov 27, 2024 •
edited
Loading

ianliuwk1019 and others added 2 commits November 27, 2024 00:42
@ianliuwk1019
Temporary fix to adjust "search_idir" to switch using 'idir-account-d…
b5e92b5 
…etail' endpoint due to IDIM Consulting new deployment breaks FAM proudction IDIR looks up IDIR user scenario.
@craigyu
fix: remove warn notification
63d805b
@craigyu craigyu marked this pull request as ready for review November 27, 2024 18:23
@craigyu craigyu self-requested a review November 27, 2024 18:23
craigyu
craigyu approved these changes Nov 27, 2024
View reviewed changes
Copy link
Collaborator

@craigyu craigyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Ian, i removed the warning banner here, hope you don't mind :P

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed for 'nr-forests-access-management_admin'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@craigyu craigyu merged commit 01ff3f6 into main Nov 27, 2024
11 of 12 checks passed
@craigyu craigyu deleted the fix/1675b-use-verifyIdirUserByIdimAccountDetail branch November 27, 2024 18:26
@github-actions github-actions bot mentioned this pull request Nov 27, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@craigyu craigyu craigyu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ianliuwk1019 @craigyu