ORV2-2755 - STOS application form and review #1674

zgong-gov · 2024-11-27T00:44:02Z

Description

Please provide a summary of the change and the issue fixed. Please include relevant context. List dependency changes.

Integrate policy engine on the frontend
Complete STOS permit type for application form and review
Add and refactor various components related to input and STOS field validation
Fix bugs related to application/permit workflows
Refactor number inputs and introduced new number input component (possible breaking change)

Type of change

Please delete options that are not relevant.

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Go through the entire process of creating/editing/amending term applications, and make sure that everything still works properly.
Create an STOS application, and fill out all the required fields, and verify that the application is created successfully, and if invalid inputs were entered, the form gives proper validation errors.
Edit a created STOS application, and verify that the existing fields and inputs are display correct values.
Verify that the STOS review and confirm page displays correct values, and that the continue button allows the application to be sent to the queue, and verify that all the queue processes work correctly.

Checklist

I have read the CONTRIBUTING doc
I have performed a self-review of my own code
I have commented my code, particularly in hard-to-understand areas
I have made corresponding changes to the documentation
My changes generate no new warnings
I have added tests that prove my fix is effective or that my feature works
New and existing unit tests pass locally with my changes
Any dependent changes have already been accepted and merged

Further comments

Please ensure that the configuration (env variables, deployment vite and yaml files) is correct for accommodating the policy engine url/integration.

Thanks for the PR!

Deployments, as required, will be available below:

Please create PRs in draft mode. Mark as ready to enable:

Analysis Workflow

After merge, new images are promoted to:

Merge Workflow

…pes files

…s with eligible subtypes instead, move hardcoded permit-specific constants from json to .ts files

…or each of the application form sections

…e dropdowns

…pplication form data

…stom form components, refactor code for permittedCommodity

… remove hardcoded test permit commodities values

… and modified vehicle details modal for STOS

…angeApplicationFormValues

…configuration loading and policy instantiation failed

…ation form values

…to drive vehicle configuration based on selected commodity

…ion and amend forms

…ead of save application hook

…cation steps for queue context, fix bug with saving power unit to inventory from permit form

frontend/package-lock.json

+    "node_modules/jsonpath-plus": {
+      "version": "7.2.0",
+      "resolved": "https://registry.npmjs.org/jsonpath-plus/-/jsonpath-plus-7.2.0.tgz",
+      "integrity": "sha512-zBfiUPM5nD0YZSBT/o/fbCUlCcepMIdP0CJZxM1+KgA4f2T206f6VAg9e7mX35+KlMaIc5qXW34f3BnwJ3w+RA==",
+      "license": "MIT",
+      "engines": {
+        "node": ">=12.0.0"
+      }
+    },


frontend/public/config/config.js

…n for staff users

sonarcloud · 2024-11-29T00:22:07Z

Quality Gate passed for 'onroutebc_policy'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

sonarcloud · 2024-11-29T00:22:19Z

Quality Gate passed for 'onroutebc dops'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

sonarcloud · 2024-11-29T00:22:23Z

Quality Gate passed for 'onroutebc_scheduler'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

sonarcloud · 2024-11-29T00:22:37Z

Quality Gate passed for 'onroutebc vehicles'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

sonarcloud · 2024-11-29T00:23:13Z

Quality Gate failed for 'onroutebc frontend'

Failed conditions
37.6% Coverage on New Code (required ≥ 80%)
3.6% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

zgong-gov added 30 commits October 16, 2024 11:10

Add additional types and fields to permitData for STOS permit type

80f63c6

Add licensedGVW field to permit vehicle details type for STOS

da00f9b

Move helper methods for permit vehicles into permit vehicle and subty…

b13b536

…pes files

Merge branch 'main' into ORV2-2755, fix conflicts

13c47cc

Merge branch 'main' into ORV2-2755

fb40a25

Install policy engine on frontend, replace ineligible vehicle subtype…

c1905c8

…s with eligible subtypes instead, move hardcoded permit-specific constants from json to .ts files

Use STOS constants for helper methods

74ec2c3

Add commodities section to the application form

e808ea2

Add application notes section to application form, refactor styling f…

cb32a9f

…or each of the application form sections

Fix width styling for vehicle details select unit or plate and vehicl…

c2b7acf

…e dropdowns

Merge branch 'main' into ORV2-2755, fix conflicts

05ce692

Add trip details section components to application form

67c8017

Remove empty highway numbers from highway sequence when serializing a…

e4e4198

…pplication form data

Add Loaded Dimensions Section to Application form, fix styling for cu…

67bb4e0

…stom form components, refactor code for permittedCommodity

Add basic policy engine logic and configuration fetching on frontend,…

1880238

… remove hardcoded test permit commodities values

Merge branch 'main' into ORV2-2755

791c09a

Fix Map type iterable error

d19d4a7

Add default vehicle configuration data to application form data

3946ad7

Refactor vehicle information section, add vehicle configuration logic…

66b18c0

… and modified vehicle details modal for STOS

Refactor policy engine and vehicle related logic

8e10f3a

Remove unused ApplicationContext in shopping cart page

4d88a03

Refactor ApplicationFormContext and move form update methods to useCh…

1168434

…angeApplicationFormValues

Add undefined for policy instantiation to distinguish between policy …

1fef863

…configuration loading and policy instantiation failed

Improve naming for hook using custom methods to update certain applic…

df1aa40

…ation form values

Add comment for describing useApplicationFormUpdateMethods hook

dce30a9

Refactor code related to using permitted commodity, add proper logic …

a6d4b52

…to drive vehicle configuration based on selected commodity

Update policy engine, refactor application serialization logic and code

00e7938

Update policy engine, add basic policy engine validation for applicat…

81914c0

…ion and amend forms

Merge branch 'main' into ORV2-2755, fix conflicts

3564d97

Update commodity related logic, add custom autocomplete component

eb3b130

zgong-gov added 3 commits November 21, 2024 16:35

Merge branch 'main' into ORV2-2755, fix conflicts

6e79a98

Handling error redirect inside application form and review pages inst…

08e2860

…ead of save application hook

Refactor ApplicationSteps to facilitate editing application and appli…

8f0a7a0

…cation steps for queue context, fix bug with saving power unit to inventory from permit form

zgong-gov requested review from cberg-aot and krishnan-aot as code owners November 27, 2024 00:44

github-advanced-security bot found potential problems Nov 27, 2024

View reviewed changes

zgong-gov added 6 commits November 26, 2024 16:50

Merge branch 'main' into ORV2-2755

9a449f2

Fix broken power unit and trailer form tests

777c498

Fix code smell

629a07f

Fix code smells, minor refactoring

f37e1b9

Fix nested string literal code smell

0587f81

Add policy endpoint url to config.js

9513e01

zgong-gov temporarily deployed to dev November 28, 2024 03:08 — with GitHub Actions Inactive

Merge branch 'main' into ORV2-2755

1afd2d1

zgong-gov temporarily deployed to dev November 28, 2024 21:12 — with GitHub Actions Inactive

Add feature flags for STOS on frontend

08ce280

zgong-gov temporarily deployed to dev November 28, 2024 22:20 — with GitHub Actions Inactive

krishnan-aot approved these changes Nov 28, 2024

View reviewed changes

krishnan-aot reviewed Nov 28, 2024

View reviewed changes

frontend/public/config/config.js Outdated Show resolved Hide resolved

Change config for policy url injection on frontend

692d12c

zgong-gov temporarily deployed to dev November 28, 2024 23:58 — with GitHub Actions Inactive

Hide submit for review button for staff users, show add to cart butto…

14ef596

…n for staff users

zgong-gov temporarily deployed to dev November 29, 2024 00:22 — with GitHub Actions Inactive

zgong-gov merged commit ffa5971 into main Nov 29, 2024
20 of 22 checks passed

zgong-gov deleted the ORV2-2755 branch November 29, 2024 00:29

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ORV2-2755 - STOS application form and review #1674

ORV2-2755 - STOS application form and review #1674

zgong-gov commented Nov 27, 2024 •

edited by github-actions bot

Loading

sonarcloud bot commented Nov 29, 2024

sonarcloud bot commented Nov 29, 2024

sonarcloud bot commented Nov 29, 2024

sonarcloud bot commented Nov 29, 2024

sonarcloud bot commented Nov 29, 2024

ORV2-2755 - STOS application form and review #1674

ORV2-2755 - STOS application form and review #1674

Conversation

zgong-gov commented Nov 27, 2024 • edited by github-actions bot Loading

Description

Type of change

How Has This Been Tested?

Checklist

Further comments

sonarcloud bot commented Nov 29, 2024

Quality Gate passed for 'onroutebc_policy'

sonarcloud bot commented Nov 29, 2024

Quality Gate passed for 'onroutebc dops'

sonarcloud bot commented Nov 29, 2024

Quality Gate passed for 'onroutebc_scheduler'

sonarcloud bot commented Nov 29, 2024

Quality Gate passed for 'onroutebc vehicles'

sonarcloud bot commented Nov 29, 2024

Quality Gate failed for 'onroutebc frontend'

zgong-gov commented Nov 27, 2024 •

edited by github-actions bot

Loading