Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ORV2-3450 Defunct/Zombie processes within Openshift dops pod environment after Financial Report Generation #1811

Merged
merged 19 commits into from
Feb 20, 2025

Conversation

praju-aot
Copy link
Collaborator

@praju-aot praju-aot commented Feb 18, 2025

Description

Please provide a summary of the change and the issue fixed. Please include relevant context. List dependency changes.

Fixes # (issue)
https://moti-imb.atlassian.net/browse/ORV2-3450

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • npm run test

Checklist

  • I have read the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have already been accepted and merged

Further comments


Thanks for the PR!

Deployments, as required, will be available below:

Please create PRs in draft mode. Mark as ready to enable:

After merge, new images are promoted to:

@praju-aot praju-aot requested a review from cberg-aot as a code owner February 19, 2025 17:58
@@ -86,6 +86,9 @@

ENV PUPPETEER_EXECUTABLE_PATH=/usr/bin/chromium-browser

# It's a good idea to use dumb-init to help prevent zombie chrome processes.
ADD https://github.com/Yelp/dumb-init/releases/download/v1.2.5/dumb-init_1.2.5_x86_64 /usr/local/bin/dumb-init

Check notice

Code scanning / Trivy

ADD instead of COPY Low

Artifact: dops/Dockerfile
Type: dockerfile
Vulnerability DS005
Severity: LOW
Message: Consider using 'COPY https://github.com/Yelp/dumb-init/releases/download/v1.2.5/dumb-init\_1.2.5\_x86\_64 /usr/local/bin/dumb-init' command instead of 'ADD https://github.com/Yelp/dumb-init/releases/download/v1.2.5/dumb-init\_1.2.5\_x86\_64 /usr/local/bin/dumb-init'
Link: DS005
…of legacy "ENV key value" format"

This reverts commit 899e68b.
@praju-aot praju-aot changed the title ORV2-3450 Cleanup Chromium process ORV2-3450 Defunct/Zombie processes within Openshift dops pod environment after Financial Report Generation Feb 20, 2025
Copy link

Copy link

Copy link

Copy link

Copy link

@praju-aot praju-aot merged commit 4fd1f4c into main Feb 20, 2025
24 checks passed
@praju-aot praju-aot deleted the fix/ORV2-3450 branch February 20, 2025 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants