Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: HDE Transactions effective date fix in spreadsheet 2769 #2796

Merged
merged 1 commit into from
Jan 13, 2024
Merged

FIX: HDE Transactions effective date fix in spreadsheet 2769 #2796

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion backend/api/services/SpreadSheetBuilder.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,7 +151,9 @@ def add_credit_transfers(self, credit_trades, user):
worksheet.write(row_index, 8, credit_trade.status.friendly_name)

# If the trade doesn't have an effective date but meets certain other criteria, write the update timestamp.
if credit_trade.update_timestamp:
if credit_trade.trade_effective_date:
worksheet.write(row_index, 9, credit_trade.trade_effective_date, date_format)
elif credit_trade.update_timestamp:
# Conditions for using the update timestamp.
approved_status = credit_trade.status.status == "Approved"
valid_trade_type = credit_trade.type.the_type in ["Credit Reduction", "Credit Validation"]
Expand Down