Fix: Effective Date fix for HDE entries-2769 #2799
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexZorkin
reviewed
Jan 15, 2024
| @@ -178,14 +178,16 @@ def approve(credit_trade, update_user=None, batch_process=False): | |||
| Sets the Credit Transfer to Approved | |||
| """ | |||
| status_approved = CreditTradeStatus.objects.get(status="Approved") | |||
| effective_date = credit_trade.trade_effective_date | |||
There was a problem hiding this comment.
just want to confirm that on historical data entry, is the trade_effective_date always set? or can it be null?
There was a problem hiding this comment.
I checked in the prod table and many records had null value.
AlexZorkin
approved these changes
Jan 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#2769