Tracking pull request to merge release-1.64.0 to master #2328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* initial commit * cleanup * more cleanup * set default permissions to AllowNone * more cleanup
* chore: removes get_serializer_context * -refactors mixin and updates the files that use it -adds extra check to credit transfers details page * -fixes rebase issues * chore: removes commented code * chore: adds mixin to sales submission list serializer so it passes test * some fixes and changes * some refactoring --------- Co-authored-by: tim738745 <[email protected]>
* chore: tests for user deetails and update * moves comments * checks for is government before displaying supplier details page (idir view) * chore: organization tests tasks: some changes to organization viewset , adds permissions fix: adds check for is government on user viewset for download_active
* fix: adds user id to basic mixin so comments can be edited chore: testing * removing extra lines * space
fix: grabs supplementary comments also using supplementary id instead of just reassessment id chore: adds empty strings to default value in user details form so there are no console errors if there are blank fields
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.