Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 167- Add Step4ward under a new cathegory at the Home page #168

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

afminguela
Copy link

@afminguela afminguela commented Nov 29, 2024

Background

Step4ward is legally and financially hosted by BCN ENG non-profit.
Even when we are already listed as a project of their open collective account https://opencollective.com/bcneng/projects/step4ward, we still need some information on the BCN ENG home page.

Proposal

  1. Create a new listing category similar to "Sponsors" called: "Projects"

  2. Add Description:

List of projects hosted by BCN Engineering and managed by community members.

  1. Add the Step4ward logo STEP4WARD-VERSION-1

  2. Link Logo to Step4ward website: https://step4ward.es/

Screenshots:
index.html
Captura de pantalla 2024-11-29 a las 13 11 45

custom.css (copied, pasted and renamed from sponsor classes)
Captura de pantalla 2024-11-29 a las 13 12 42

Added Step4ward logo to a new folder in Static/images called projects-logos
Captura de pantalla 2024-11-29 a las 13 13 50

Summary: Having done the general purpose, along the way I have encountered:

Final result:

Captura de pantalla 2024-11-29 a las 13 16 22

*** Edited: 30/11/24- content moved to Issue 168

@gonzaloserrano
Copy link
Contributor

gonzaloserrano commented Nov 29, 2024

Hi, thanks for the PR!
I don't think I can check it in detail today, but some things caught my attention:

  • why does the public directory need to be committed? before it was not there
  • consider using a global .gitignore to avoid committing files such as .DS_Store, which is something local to your environment (e.g macOS caching images for Finder).
  • the netlify deployment is broken, so we cannot see the preview of the changes

@gonzaloserrano
Copy link
Contributor

If you take a look at the netlify logs, looks like the theme git submodule was updated to a git hash that it cannot find. That should be somehow fixed too.

@afminguela
Copy link
Author

Hi!!,
I made some GIT "magical movements", back to the last commit before "The Hugo Incident" and now Netlify can build and deploy the preview.

I´m going to open a new Issue and PR to solve The Hugo Incident. But the Solution is on the explanation of this PR.

@gonzaloserrano
Copy link
Contributor

Looks much better, thanks. Can you please remove the .DS_Store files from the PR as I asked in an earlier comment? With that I think we could merge it.

Prevents committing Visual Studio Code configuration files by adding .vscode to .gitignore
@gonzaloserrano
Copy link
Contributor

Hi,
You've added the .DS_Store file to the .gitignore but the files were already committed, so you need to delete them. Go to the "Files changed" tab and see them there.

Regarding:

content moved to Issue 168

Small detail: if you write #169, github will create a link to the issue (and I say 169 because the 168 is this one).

Nit: regarding the screenshots you added to the description, you don't need to add the description of the code changes. I can see that in the files changed tab.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants