Merge pull request #79 from bcnmy/rc/feedbackupdates

adress client feedback
bcnmy · Oct 3, 2023 · 9009469 · 9009469
2 parents 5969605 + 8208798
commit 9009469
Show file tree

Hide file tree

Showing 5 changed files with 15 additions and 12 deletions.
diff --git a/docs/Biconomy AA Stack/Bundler/initialization.md b/docs/Biconomy AA Stack/Bundler/initialization.md
@@ -7,7 +7,7 @@ sidebar_position: 3
 | Key                | Description |
 | -------------------| ------------- |
 | bundlerUrl         | Represent ERC4337 spec implemented bundler url. you can get one from biconomy dashboard. Alternatively you can supply any of your preferred|
-| chainId            | This represents the network your smart wallet transactions will be conducted on. Take a look following Link for supported chain id's |
+| chainId            | This represents the network your smart wallet transactions will be conducted on. [Click here for supported Chains ](/docs/supportedchains/)|
 | entryPointAddress  | Since entrypoint can have different addresses you can call getSupportedEntryPoints() on bundler instance for supported addresses list|
 
 ```typescript

diff --git a/docs/Biconomy AA Stack/Modules/description.md b/docs/Biconomy AA Stack/Modules/description.md
@@ -14,4 +14,4 @@ Refer to the chart below for the modules currently available with the Biconomy S
 | ECDSA Ownership Module | This module relies on ECDSA. The EOA owners public key is needed to sign and verify a message. This can also be used as default and active validation modules. | 0x0000001c5b32F37F5beA87BDD5374eB2aC54eA8e |
 | MultiChain Validation Module | This module is an extenstion of the ECDSA Module. In addition to the ECSA functionality this module allows for dispatching multiple userOps to different EVM chains. Can be used in place of ECDSA Module as default and active validation modules. | 0x000000824dc138db84FD9109fc154bdad332Aa8E |
 | Session Key Manager Module | This module enables the use of sessions with session validation modules which can be deployed at different addresses. The validation modules themselves do not get implemented as modules but can be managed by this one. This can only be used as an active validation module.   | 0x000000456b395c4e107e0302553B90D1eF4a32e9 |
-| Batched Session Router Module | This module works with Session Ket Manager Module. Normally only one session key signed userOp could be executed, this module allows for multiple session operations. | 0x000008dA71757C0E1D83CE56c823e25Aa49bC058 |
+| Batched Session Router Module | This module works with Session Key Manager Module. Normally only one session key signed userOp could be executed, this module allows for multiple session operations. | 0x000008dA71757C0E1D83CE56c823e25Aa49bC058 |
diff --git a/docs/howtos/creatingAccounts/ethers.md b/docs/howtos/creatingAccounts/ethers.md
@@ -25,6 +25,7 @@ import { IBundler, Bundler } from '@biconomy/bundler'
 import { BiconomySmartAccountV2, DEFAULT_ENTRYPOINT_ADDRESS } from "@biconomy/account"
 import { Wallet, providers, ethers } from 'ethers';
 import { ChainId } from "@biconomy/core-types"
+import { ECDSAOwnershipValidationModule, DEFAULT_ECDSA_OWNERSHIP_MODULE } from '@biconomy/modules'
 ```
 
 ### Create a Signer using a Private Key:
@@ -54,16 +55,18 @@ const paymaster: IPaymaster = new BiconomyPaymaster({
   paymasterUrl: '' 
 })
 
-const module = await ECDSAOwnershipValidationModule.create({
-  signer: wallet,
-  moduleAddress: DEFAULT_ECDSA_OWNERSHIP_MODULE
-})
 ```
 
 ### Create the Biconomy Smart Account
 
 ```typescript
 async function createAccount() {
+
+  const module = await ECDSAOwnershipValidationModule.create({
+  signer: wallet,
+  moduleAddress: DEFAULT_ECDSA_OWNERSHIP_MODULE
+  })
+
   let biconomySmartAccount = await BiconomySmartAccountV2.create({
     chainId: ChainId.POLYGON_MUMBAI,// or any supported chain of your choice
     bundler: bundler,
@@ -130,7 +133,7 @@ const connect = async () => {
       const provider = new ethers.providers.Web3Provider(ethereum)
       await provider.send("eth_requestAccounts", []);
       const signer = provider.getSigner();
-      const ownerShipModule = ECDSAOwnershipValidationModule.create({
+      const ownerShipModule = await ECDSAOwnershipValidationModule.create({
         signer: signer,
         moduleAddress: DEFAULT_ECDSA_OWNERSHIP_MODULE
       })

diff --git a/docs/supportedchains/supportedchains.md b/docs/supportedchains/supportedchains.md
@@ -1,19 +1,19 @@
 ---
-sidebar_label: Gas Sponsorship
+sidebar_label: Paymaster and Bundler Chains
 sidebar_position: 1
 ---
 
-# Gas Sponsorship
+# Paymaster and Bundler Chains
 
-List of chains supported by our Paymaster for gas sponsorship.
+List of chains supported by our Paymasters and Bundlers.
 
 ## Mainnet Chains
 1. Ethereum
 2. Polygon Mainnet
 3. BSC Mainnet
 4. Polygon zkEVM Mainnet
 5. Arbitrum One Mainnet
-6. Arbitrum Nove Mainnet
+6. Arbitrum Nova Mainnet
 7. Optimism Mainnet
 8. Avalanche Mainnet
 9. Base Mainnet

diff --git a/docs/tutorials/nextjs/sdkintegration.md b/docs/tutorials/nextjs/sdkintegration.md
@@ -31,7 +31,7 @@ Notice I changed my title and description, feel free to do that. On the main tag
 
 ## Set up Particle Auth
 
-Now we're going to leverage Particle Auth through the SDK to set up social logins. Remember we're focusing here on users who have never onboarded onto web3 via a wallet and just want o experience minting their first NFT. 
+Now we're going to leverage Particle Auth through the SDK to set up social logins. Remember we're focusing here on users who have never onboarded onto web3 via a wallet and just want to experience minting their first NFT. 
 
 Let's import the Particle Auth Package