Merge pull request #74 from bcnmy/rc/methodupdates

Rc/methodupdates
bcnmy · Sep 26, 2023 · c9de23f · c9de23f
2 parents db69927 + 8168486
commit c9de23f
Show file tree

Hide file tree

Showing 4 changed files with 12 additions and 21 deletions.
diff --git a/docs/quickstart.md b/docs/quickstart.md
@@ -118,21 +118,16 @@ First we import our Module:
 ```typescript
 import { ECDSAOwnershipValidationModule, DEFAULT_ECDSA_OWNERSHIP_MODULE } from "@biconomy/modules";
 ```
-Now initialize it: 
+Now let's initialize the module and pass it to our account creation config:
 
 ```typescript
+async function createAccount() {
 
-const module = await ECDSAOwnershipValidationModule.create({
+  const module = await ECDSAOwnershipValidationModule.create({
     signer: wallet,
     moduleAddress: DEFAULT_ECDSA_OWNERSHIP_MODULE
   })
 
-```
-
-Now with the config setup let's create a smart account:
-
-```typescript
-async function createAccount() {
   let biconomySmartAccount = await BiconomySmartAccountV2.create({
   signer: wallet,
   chainId: ChainId.POLYGON_MUMBAI,
@@ -141,7 +136,6 @@ async function createAccount() {
   defaultValidationModule: module,
   activeValidationModule: module
 })
-  console.log("owner: ", biconomySmartAccount.owner)
   console.log("address: ", await biconomySmartAccount.getAccountAddress())
   return biconomySmartAccount;
 }

diff --git a/docs/smartAccountv1/quickstartv1.md b/docs/smartAccountv1/quickstartv1.md
@@ -218,7 +218,7 @@ async function createAccount() {
   const biconomyAccount = new BiconomySmartAccount(biconomySmartAccountConfig)
   const biconomySmartAccount =  await biconomyAccount.init()
   console.log("owner: ", biconomySmartAccount.owner)
-  console.log("address: ", await biconomySmartAccount.getSmartAccountAddress())
+  console.log("address: ", await biconomySmartAccount.getAccountAddress())
   return biconomyAccount
 }
 async function createTransaction() {

diff --git a/docs/tutorials/React_vite/sdk-integration.md b/docs/tutorials/React_vite/sdk-integration.md
@@ -181,9 +181,8 @@ async function setupSmartAccount() {
         defaultValidationModule: module,
         activeValidationModule: module
       })
-      console.log("owner: ", biconomySmartAccount.owner)
       console.log("address: ", await biconomySmartAccount.getAccountAddress())
-      console.log("deployed: ", await biconomySmartAccount.isAccountDeployed( await biconomySmartAccount.getAccountAddress()))
+      console.log("deployed: ", await biconomySmartAccount.isAccountDeployed())
 
       setSmartAccount(biconomySmartAccount)
       setLoading(false)

diff --git a/docs/tutorials/nodejs/initializeaccount.md b/docs/tutorials/nodejs/initializeaccount.md
@@ -87,18 +87,17 @@ import { ECDSAOwnershipValidationModule, DEFAULT_ECDSA_OWNERSHIP_MODULE } from "
 
 Now lets initialize the module:
 
-```typescript
-const module = await ECDSAOwnershipValidationModule.create({
-  signer: wallet,
-  moduleAddress: DEFAULT_ECDSA_OWNERSHIP_MODULE
-})
-```
-
 
-Now lets use the create method on the `BiconomySmartAccountV2` class to create a new instance of our smart account:
+Now lets initialize the module and use the create method on the `BiconomySmartAccountV2` class to create a new instance of our smart account:
 
 ```typescript
 async function createAccount() {
+
+  const module = await ECDSAOwnershipValidationModule.create({
+  signer: wallet,
+  moduleAddress: DEFAULT_ECDSA_OWNERSHIP_MODULE
+  })
+
   let biconomySmartAccount = await BiconomySmartAccountV2.create({
     chainId: ChainId.POLYGON_MUMBAI,
     bundler: bundler,
@@ -107,7 +106,6 @@ async function createAccount() {
     defaultValidationModule: module,
     activeValidationModule: module
 })
-  console.log("owner: ", biconomySmartAccount.owner)
   console.log("address: ", await biconomySmartAccount.getAccountAddress())
   return biconomySmartAccount;
 }