Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mocha Config: Enable Mocha Test Explorer #101

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

TheArhaam
Copy link

Description

The repository was missing a .mocharc.js that makes it compatible with Mocha Test Explorer.

Changes made:

  • Configured a mocharc.js file
  • Fixed missing type assertions in the test suite for ExecutorManager, MockAdaptor, MockSwapRouter and UniswapAdaptor. The missing assertions were preventing the Test Explorer from running the tests.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

  • Manual Testing

    • All Test Suites showed up in the test explorer: Screenshot 2023-05-03 at 2 40 40 PM
      NOTE: Certain test cases failed but not as a result of any changes made in this PR, fixing those errors is beyond the scope of this PR.
  • Automated Testing

    • NA

Test Configuration:

  • NA

Steps to reproduce

  • NA

Using New Sample API

  • NA

Automated Tests Added/Updated

  • NA

Coverage

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant