Release/nexus v1.2.0 ep v0.7 #242

filmakarov · 2025-02-20T06:07:00Z

EIP-7702 Support for validateUserOp: feat: add eip7702 support #227
EIP-7702 Support for Module Enable Mode: Make Module Enable Mode compatible with 7702 #236
Pre-validation Hooks for Resource Locking: feat: add prevalidation hook support #232
Secure batch decode implementation #235
Default validator for ep v7 Nexus version #245
PREP support #246
fix(IPreValidationHook): make 4337 hook non-view #250

Remove dependency of tests on scripts

feat: add eip7702 support

Signed-off-by: Manank Patni <[email protected]>

Fix test case for delegate call test_ExecuteDelegateCallFromExecutor_Success

feat: add prevalidation hook support

Make Module Enable Mode compatible with 7702

Secure batch decode implementation

openzeppelin-code · 2025-02-20T06:12:16Z

Release/nexus v1.2.0 ep v0.7

Generated at commit: efd9f1f437292c0700d5d406a1d8e9fffe3e2d08

🚨 Report Summary

	Severity Level	Results
Contracts	Critical High Medium Low Note Total	1 1 0 6 30 38

For more details view the full report in OpenZeppelin Code Inspector

PREP support

On ERCxxxReceived hotfix

Revert "Merge pull request #247 from bcnmy/fix/onERCxxxReceive-hotfix" This reverts commit 77cd940, reversing changes made to bbda8f9.

github-actions · 2025-03-03T19:20:42Z

🤖 Slither Analysis Report 🔎

Slither report

# Slither report

THIS CHECKLIST IS NOT COMPLETE. Use --show-ignored-findings to show all the results.
Summary
🟡 - unused-return (2 results) (Medium)

constable-states (2 results) (Optimization)

unused-return

🟡 Impact: Medium
🟡 Confidence: Medium

ID-0
ModuleManager._uninstallExecutor(address,bytes) ignores return value by executor.excessivelySafeCall(gasleft()(),0,0,abi.encodeWithSelector(IModule.onUninstall.selector,disableModuleData))

base/ModuleManager.sol#L242-L246

ID-1
ModuleManager._uninstallValidator(address,bytes) ignores return value by validator.excessivelySafeCall(gasleft()(),0,0,abi.encodeWithSelector(IModule.onUninstall.selector,disableModuleData))

base/ModuleManager.sol#L219-L228

constable-states

Impact: Optimization
🔴 Confidence: High

ID-2
RegistryAdapter.registry should be constant

base/RegistryAdapter.sol#L10

ID-3
RegistryFactory.threshold should be constant

factory/RegistryFactory.sol#L38

_This comment was automatically generated by the GitHub Actions workflow._

fix(IPreValidationHook): make 4337 hook non-view

highskore and others added 29 commits December 10, 2024 11:34

feat: add eip7702 support

3c08abd

chore: fix function ordering

5689c78

fix(hardhat): fix hardhat test

6a9f7a0

chore(K1ValidatoFactory): remove unused error

c3b4fc6

chore(MockValidator): revert removing require

691cdff

refactor(validateUserOp): check happy path first

bb7f70e

refactor(_checkUserOpSignature): check happy path first

d0cc50e

fix tests dep in script

dd96bd7

Merge pull request #230 from bcnmy/fix/scripts-dep

3fc0861

Remove dependency of tests on scripts

Merge pull request #227 from highskore/feat/eip7702-support

036e348

feat: add eip7702 support

Fix test case for delegate call

fb07c7e

Signed-off-by: Manank Patni <[email protected]>

Merge pull request #229 from Man-Jain/issue-228

be790e8

Fix test case for delegate call test_ExecuteDelegateCallFromExecutor_Success

feat: add prevalidation hook support

8cd5169

chore: fix linter issues

ff8f36f

fix: init userOp to op

731daf9

fix: use 2771 for 4337 prevalidation msg.sender

ab75991

test(pre-validation/multiplexer): add k1 validator tests

859bf3b

fix: make MockResourceLock 4337 storage compliant

683ee6e

fix: remove account from 1271 interface

84f9aa0

Merge pull request #232 from highskore/feat/pre-validation-hooks

a078cd7

feat: add prevalidation hook support

secure batch decode + test fix

451ed01

module enable mode for uninitialized 7702 acct

cdd799b

7702 enable mode

76b5ab4

refactor

1e4eab1

Merge pull request #236 from bcnmy/feat/7702-compatible-moduleEnableMode

f611a15

Make Module Enable Mode compatible with 7702

Merge pull request #235 from bcnmy/fix/decodeBatch-security

71218d6

Secure batch decode implementation

reduce size

8c0bbfe

builds within size

87b5df4

fix verision

9e7efbc

Filipp Makarov and others added 18 commits March 3, 2025 11:59

prep verif

85ff44f

reduce size

50b94c1

fix tests

5b23ccf

test PREP

8622e2d

deps

2aa8342

clean package

6cdb51d

package fix

bfa0d36

rfctr

d9429c1

Merge pull request #246 from bcnmy/feat/epv7/prep-support

bbda8f9

PREP support

fix fallback onERC

639bbdf

Merge branch 'feat/epv7/prep-support' into fix/onERCxxxReceive-hotfix

62a0bc2

proper tests

d24a68d

complex return handling by fallback test

13964fc

test erc2771 sender handling

7df8eaf

Merge pull request #247 from bcnmy/fix/onERCxxxReceive-hotfix

77cd940

On ERCxxxReceived hotfix

fix fallback

9344ddf

additional test

07fd845

Introducing those changes in a separate PR

e9cbc56

Revert "Merge pull request #247 from bcnmy/fix/onERCxxxReceive-hotfix" This reverts commit 77cd940, reversing changes made to bbda8f9.

Filipp Makarov and others added 11 commits March 3, 2025 22:50

manual hooking for fallback

14583d6

rnm test

32b0976

no hook onERCxxx

8101078

address comments

fb7d6fe

revert early

25b3784

remove excessive isContract check in onInstall

495f401

fix versions

dcaa4ee

revert isContract check removal

13c250d

fix conflicts

52efb2c

fix(IPrevalidationHook): make 4337 hook non-view

cc6e735

Merge pull request #250 from highskore/fix/pvh-non-view

efd9f1f

fix(IPreValidationHook): make 4337 hook non-view

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Release/nexus v1.2.0 ep v0.7 #242

Release/nexus v1.2.0 ep v0.7 #242

filmakarov commented Feb 20, 2025 •

edited

Loading

openzeppelin-code bot commented Feb 20, 2025 •

edited

Loading

github-actions bot commented Mar 3, 2025

unused-return

constable-states

Release/nexus v1.2.0 ep v0.7 #242

Are you sure you want to change the base?

Release/nexus v1.2.0 ep v0.7 #242

Conversation

filmakarov commented Feb 20, 2025 • edited Loading

openzeppelin-code bot commented Feb 20, 2025 • edited Loading

Release/nexus v1.2.0 ep v0.7

🚨 Report Summary

github-actions bot commented Mar 3, 2025

🤖 Slither Analysis Report 🔎

Slither report

unused-return

constable-states

filmakarov commented Feb 20, 2025 •

edited

Loading

openzeppelin-code bot commented Feb 20, 2025 •

edited

Loading