Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve inference for function ∂fξ_∂x_hypersurface #128

Merged
merged 1 commit into from
Jul 26, 2024
Merged

Improve inference for function ∂fξ_∂x_hypersurface #128

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions src/mapping/ref2phys.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,7 +148,7 @@
return ForwardDiff.jacobian(f, ξ) * mapping_jacobian_inv(ctype, cnodes, ξ)
end

function ∂fξ_∂x_hypersurface(f, ::Val{1}, ctype::AbstractEntityType, cnodes, ξ)
function ∂fξ_∂x_hypersurface(f::F, ::Val{1}, ctype::AbstractEntityType, cnodes, ξ) where {F}

Check warning on line 151 in src/mapping/ref2phys.jl

View check run for this annotation

Codecov / codecov/patch

src/mapping/ref2phys.jl#L151 

Added line #L151 was not covered by tests
# Gradient in the reference domain. Add missing dimensions. Warning : we always
# consider a hypersurface (topodim = spacedim - 1) and not a line in R^3 for instance.
# Hence we always add only one 0.
Expand All @@ -161,7 +161,13 @@
return transpose(inv(J)) * ∇f
end

function ∂fξ_∂x_hypersurface(f, ::Val{N}, ctype::AbstractEntityType, cnodes, ξ) where {N}
function ∂fξ_∂x_hypersurface(

Check warning on line 164 in src/mapping/ref2phys.jl

View check run for this annotation

Codecov / codecov/patch

src/mapping/ref2phys.jl#L164 

Added line #L164 was not covered by tests
f::F,
::Val{N},
ctype::AbstractEntityType,
cnodes,
ξ,
) where {F, N}
# Gradient in the reference domain. Add missing dimensions. Warning : we always
# consider a hypersurface (topodim = spacedim - 1) and not a line in R^3 for instance.
# Hence we always add only one 0.
Expand Down
Loading